PHP Form Problems

[eba420]

I am currently writing a PHP script that will add a file to a MySQL data base. The php script is called from a form. The add function is sort of working properly, it is adding a blank line to the data base. Below is the code that I am using. $tablename is passed from an if statement.

function callconnection ($tablename){
$host = "server";
$user = "username";
$password = "******";
$dbname = "dbname";
@mysql_select_db("$dbname")
$link= mysql_connect($host, $user, $password);
$query = "insert into $tablename(cds) values ('$cdname')";
print("The query id:<br>$query<p>\n");
if(mysql_db_query ($dbname, $query, $link)){
print("The addition was successful<br>\n");
}else{
print("The addition failed<br>\n");
}
mysql_close($link);
}

any help as to what i might be missing will be greatly appreciated. I know the var from the form is in the $cdname var because i used an echo statement and it printed properly just for some reason it is not being added into the database, just a blank line.

[eba420]

Sorry there is a ; at the end of the @mysql_select_db statement it just didnt copy over.

[ryadex]

It appears that you have an error in your query.

Instead of:

$query = "insert into $tablename(cds) values ('$cdname')";

Try removing the quotes from around $cdname, giving you:

$query = "insert into $tablename(cds) values ($cdname)";

This is what I use:

$query = "insert into $tableName ($fields) values ($values)";

Hope it helps!

[eba420]

Same thing still getting the blank line. Below is the results of the if statments that it prints

with changes made from last response
The query id:
insert into a (cds) values ()

with original code
The query id:
insert into a (cds) values ('')

[Anon]

Hi Eric,
If the data type of the coulmn is VARCHAR then you should put quotes it's not the cause of the error.
When you call this function the variables declared in this function and the table name you are passing as an argument only availabe,the variable $cdname is not available 'cas it's out side the function.You need to pass this variable also as an argument or you need to declare it as global variable.

Cheers
Ajay