php4 differences from php3

[Anon]

Is there any reason this script WILL work in PHP3, but not in PHP4?

<?
$db_name = "classDB";
$table_name = "class";
$sql = "SELECT *
FROM $table_name
WHERE formtype = \"default\"
";

$connection = mysql_connect("localhost", "me", "mypassword") or die("Couldn't connect.");

$db = mysql_select_db($db_name, $connection) or die("Couldn't select database.");

$result = mysql_query($sql,$db);

while ($myrow = mysql_fetch_row($result)) {

echo "<option value=$myrow[0]>$myrow[1]";}

?>

[[deleted]]

Not that I can see.

Do you have a problem yet?

[Anon]

yes I do, it will not connect to the database, it gives me this error:

<b>Warning</b>: Supplied argument is not a valid MySQL-Link resource in <b>/home/sites/site1/web/test/calendar/admin/temp/classsetup.php</b> on line <b>77</b><br>
<br>
<b>Warning</b>: Supplied argument is not a valid MySQL result resource in <b>/home/sites/site1/web/test/calendar/admin/temp/classsetup.php</b> on line <b>83</b><br>

These refer to the suplied code:

<?
$db_name = "classDB";
$table_name = "class";
$sql = "SELECT *
FROM $table_name
WHERE formtype = \"default\"
";

                      $connection = mysql_connect("localhost", "me", "mypassword") or
                      die("Couldn't connect."); 

(line77 ---) $db = mysql_select_db($db_name, $connection) or die("Couldn't select
database.");

(line83 ---) $result = mysql_query($sql,$db);

                      while ($myrow = mysql_fetch_row($result)) { 

                      echo "<option value=$myrow[0]>$myrow[1]";} 

                      ?>

This code worked before the upgrade to PHP4

[Anon]

This does work in PHP3 but not in PHP4:

<?
$db_name = "classDB";
$table_name = "class";
$sql = "SELECT *
FROM $table_name
WHERE formtype = \"default\"
";

$connection = mysql_connect("localhost", "me", "mypassword") or
die("Couldn't connect.");

$db = mysql_select_db($db_name, $connection) or die("Couldn't select
database.");

$result = mysql_query($sql,$db);

This works in both:

<?

$db_name = "classDB";

$table_name = "class1";

$sql = "SELECT *
FROM $table_name
WHERE formtype = \"custom\"
";

$connection = mysql_connect("localhost", "root", "cobalt-mysql") or die("Couldn't connect.");

mysql_select_db("classDB", $connection) or die("Couldn't select database.");
$result = mysql_query($sql);

[[deleted]]

Not solved, worked-around.

$db = mysql_select_db($db_name, $connection) or die("Couldn't select database.");

$result = mysql_query($sql,$db);

This will never work, not in php3 and not in php4.

mysql_select_db() does not return a database link identifier.
It only returns TRUE/FALSE depending on wether the database-selection worked or not.

Change
$result = mysql_query($sql,$db);
to
$result = mysql_query($sql,$connection);
and it should work again.

This kind of problem occurs every time you dont use error-checking.
read this:
http://www.xs4all.nl/~vinny/index.html#4

[Anon]

vincent wrote:

Not solved, worked-around.

$db = mysql_select_db($db_name, $connection) or die("Couldn't select >database.");

$result = mysql_query($sql,$db);

This will never work, not in php3 and not in php4.

mysql_select_db() does not return a database link identifier.
It only returns TRUE/FALSE depending on wether the database-selection >worked or not.

Change
$result = mysql_query($sql,$db);
to
$result = mysql_query($sql,$connection);
and it should work again.

This kind of problem occurs every time you dont use error-checking.
read this:
http://www.xs4all.nl/~vinny/index.html#4

If you read the last post I made, I did do this, however you are mistaken, the first way DID work just fine in PHP3, had it running just fine in a commercial web site.

moonie 😉

[[deleted]]

I find it hard to believe that this code worked in PHP3.

Because the manual says:

bool mysql_select_db (string database_name [, resource link_identifier])

Returns: TRUE on success, FALSE on error.

You simply cannot use the output of this function as a link-identifier.

Either they changed the specs from php3 to php4 (no mention of that in the manual)
or you did something else (like leave the connection identifier out of the mysql_query as in your 'solution' 🙂 )

But anyway, stranger things have happened, PHP is always under development 🙂
The link I gave you describes the 'proper' way to use MYSQL with PHP, and includes error checking. That will report exactly what's wrong with a query or a connection, so you shouldn't get 'strange' problems like this anymore.

[Anon]

I agree that it shouldn't have worked, however this was actually part of a script that I got from this site and modified for my use. We actually have 2 RaQ3's, one has PHP3 and now this one has PHP4. That piece of code is currently working just fine on the one with PHP3, I am going to modify it as well as I am also going to upgrade that one to PHP4.

moonie 😉