Select E-mails from db, then send mail

[bjblackmore]

Hi,
I have the following code, which I'm sure should work, but doesn't, can anyone see anything wrong with it? Its just meant to get email from a table, where is_confirmed=1 and then send a newsletter, to all the e-mail address's in the database.

function send_newsletter($date,$subject,$text) {
mysql_select_db("hkihotels");
$query="SELECT email FROM test_table WHERE is_confirmed='1'";
$result=mysql_query($query);
if (!$result) {
$feedback .= ' ERROR - No Registered Users ' . mysql_error();
return false;
} else {
$count=0;
while( $email = mysql_fetch_row($result));
{
mail ($email[0], $subject, $text, "From: [e-mail]");
$count++;
}
$feedback .= ' Successfully Sent Newsletter ';
return true;
}
}

If anyone can help, I'd greatly appreciate it.
Ben

[morphy]

uhm... im still asking myself which is the best solution for a news letter cause if u have hundreds of users this script never end or worst end without doing the entire job... does it?
any idea about my prob?
could be a better solution to implement a service which is called and forgotten by the script and send the emails as blocks of To and BCc?
could a mail server use a single email address as a group of lots emails?
waiting for infos... have a nice working day 😉

[bjblackmore]

Finally got it working, here is the code....
function send_newsletter($date,$subject,$text) {
global $feedback;
mysql_select_db("hkihotels");
$query="SELECT email FROM test_table WHERE is_confirmed='1'";
$result=mysql_query($query);
if (!$result) {
$feedback .= ' ERROR - No Registered Users ' . mysql_error();
return false;
} else {
$count=0;
while( list($email) = mysql_fetch_row($result))
{
mail ($email, $subject, $text, "From: [e-mail]");
$count++;
}
$feedback .= " Successfully Sent Newsletter to $count Subscribers";
return true;
}
}

As for it taking a while, I hadn't really thought of it, however, now you mention it, I can see that it would get very slow if you have 100s of users. Not too sure how to solve this. I read a book (php & mysql web development) very good, and it used code simular to the above (didn't use list()).
Anyway, it didn't mention how it would cope if a huge load of put on it.
If anyone has any ideas, let me (and Morphy) know.
Many Thanks
Ben

[Anon]

If you guys are on a unix based system, I would recommend you implement majordomo.

Have your email addresses in a (mysql?) database, and simply update a text file which majordomo controls. (i.e: the user listing).

Also, as far as the first solutions goes, it would make much more sense to propagate a BCC list and inject one message which the mail server will then take care of.

Hope this helps.

-m.