help!

[Anon]

Hi,

I'm using the following simple script to include a text file according to the $id passed to it by the preceeding form field.

<?php include("annotate.php.$id"); ?>

But, if someone enters an incorrect $id, i.e. there is no such text file, I get a 'failed to include' parse error. Is there any way of having, instead, a 'file not found, try again' type message? Maybe by scanning the files in the directory?

I'm a complete beginner so please use simple terms if poss.

Thanks in advance, Andy.

[khaine]

You could try putting @ before the command i.e.

@include("filename");

or you could use.

<?

$dir_name="/path/to/dir";
$dir=opendir($dir_name);

$got=0;
while ( $filename = readdir($dir) )
{

if ( $filename == "annotate.php.".$id )
{
    $got=1;
}

}

if ( $got == 1 )
{
include("annotate.php.$id");
}
else
{
echo "File not found";
}

?>

The second way is preferable as you can find if the file exists instead of just suppressing the error message.

Mark

[Anon]

Use:

if (file_exists("annotate.php.$id")){
include("annotate.php.$id");
}else{
echo("ID $id is incorrect.");
}

Smth like this should help :-)

[khaine]

shows that I am half asleep I forgot about that command.

[Anon]

lol thanks to you both, can't believe how quick the responses were.

Cheers chaps, hope you won't mind my further posting should I encounter difficulty!

[[deleted]]

Never EVER use the @ instead of proper error_checking.

shame on you for even suggesting it :-)

[Anon]

vincent,

just curious:

other than the obvious security and 'difficult to run debug' reason - is there something in particular you have against the '@'?

-m.

[[deleted]]

There's nothing really 'bad' about the @, but people don't seem to know when to use it and what to do when they use it.