variable

[ace21]

Is it know to be slow to loop through all posted variables like in the following code.

while (list($var, $value) = each($HTTP_POST_VARS))
{

if((($var != "address")||($var != "additional") || ($var!="special")||($var != "acct")) && ($value != ""))
{

   		$sql ="select * from KSSProducts where StockNumber='$var'";
   		$result = mysql_query($sql,$db);
   		if($row = mysql_fetch_array($result))
   		{
   			echo "<TR><TD>$value</TD><TD>".$row["ItemName"]."</TD></TR>";
   		}
   		//echo "$var = $value<br>\n";
 			}
   		$i++;
}

}

because when I run the above code it is pretty slow. Could the problem be that it is going through over 100 posted variables? Yet since that is the case I don't want to hand code in all those variable names.

Any suggested would be appreciated.

Ace21

[Anon]

I am afraid I don't have any real good suggestions, but one thing that will give it a minor boost in speed, is to not use double quotes on a literal string. PHP will process it faster if you use single quotes on literal strings. Only use double quotes if it has to parse a variable within the string.

if ($var != '')

This is a very minor boost in efficiency, but it adds up in the long run.

Also, you may consider using checkboxes where possible in your form input. A checkbox value is only passed to the script if it has been checked off. So if you have 100 checkboxes, but only 1 gets checked by the user, then it only passes the one value. If you can implement checkboxes, you may not have to ititerate over 100 variables. You will have to decide if this is aplicable to your situation.