Parser errors!

Anon

Dear Readers,

I'm learning PHP & SQL besides my school, I'm 16 years old and have a question!

This is a difficult question I think, i tried to make a PHP script I write it below, but it doesn't work. PostgreSQL gives an Parser error at line 16. I already made a set of PHP script but I can't get this one work!

Can anybody tell me what's wrong?

<body>
<?php
dl("pgsql.so");
$db = pg_connect("dbname=literatuur user=htdocs");
$query = "SELECT auteur1, auteur2, auteur3, titel, jaar, bron, afl, trefw1, trefw1, trefw1, trefw2, trefw2, trefw2, trefw3, trefw3, trefw3, tijdschrift FROM literatuur WHERE id='$id';";
$result = pg_exec($db, $query);
if (!$result) {printf ("ERROR"); exit;}
$numrows = pg_numrows($result);
$row=0;
do
{
$myrow = pg_fetch_row ($result,$row);
printf ("<FORM ACTION=literatuurveranderen.php3 METHOD=POST><TABLE BORDER=0 BGCOLOR=#F0F291 CELLSPACING=0 CELLPADDING=5>\n");
printf ("<TR><TD>Auteur 1</TD><TD><INPUT TYPE=hidden NAME=id VALUE=$id><INPUT TYPE=text NAME=auteur1 SIZE=40 MAXLENGTH=40 VALUE=%s></TD></TR>", myrow[0]);
printf ("<TR><TD>Auteur 2</TD><TD><INPUT TYPE=text NAME=auteur2 SIZE=40 MAXLENGTH=40 VALUE=%s></TD></TR>", myrow[1]);
printf ("<TR><TD>Auteur 3</TD><TD><INPUT TYPE=text NAME=auteur3 SIZE=40 MAXLENGTH=80 VALUE=%s></TD></TR>", myrow[2]);
printf ("<TR><TD>Titel</TD><TD><INPUT TYPE=text NAME=titel SIZE=40 MAXLENGTH=125 VALUE=%s></TD></TR>", myrow[3]);
printf ("<TR><TD>Jaar</TD><TD><INPUT TYPE=text NAME=jaar SIZE=4 MAXLENGTH=4 VALUE=%s></TD></TR>", myrow[4]);
printf ("<TR><TD>Bron</TD><TD><INPUT TYPE=text NAME=bron SIZE=40 MAXLENGTH=125 VALUE=%s></TD></TR>", myrow[5]);
printf ("<TR><TD>Aflvering</TD><TD><INPUT TYPE=text NAME=afl SIZE=40 MAXLENGTH=125 VALUE=%s></TD></TR>", myrow[6]);
printf ("<TR><TD>Trefwoord 1</TD><TD><SELECT NAME=trefw1><OPTION VALUE=%s>%s<OPTION VALUE=%s>-------------------------<OPTION VALUE=-leeg-><OPTION VALUE=assessment>assessment<OPTION VALUE="ass.center">assessment center<OPTION VALUE=beoordeling>beoordeling<OPTION VALUE=betrouwbaarheid>betrouwbaarheid<OPTION VALUE=capaciteiten>capaciteiten<OPTION VALUE=ethiek>ethiek<OPTION VALUE=fairness>fairness<OPTION VALUE=functie>functie analyse<OPTION VALUE=generalisatie>generalisatie<OPTION VALUE=hrm>HRM<OPTION VALUE=interview>interview<OPTION VALUE=management>management<OPTION VALUE=manual>manual<OPTION VALUE=motivatie>motivatie<OPTION VALUE=persoonlijkheid>persoonlijkheid<OPTION VALUE=plaatsing>plaatsing<OPTION VALUE=psychometrie>psychometrie<OPTION VALUE=selectie>selectie<OPTION VALUE=statistiek>statistiek<OPTION VALUE=strategie>strategie<OPTION VALUE=tests>tests<OPTION VALUE=utiliteit>utiliteit<OPTION VALUE=validiteit>validiteit<OPTION VALUE=werving>werving</SELECT></TD></TR>", myrow[7], myrow[8], myrow[9]);
printf ("<TR><TD>Trefwoord 2</TD><TD><SELECT NAME=trefw2><OPTION VALUE=%s>%s<OPTION VALUE=%s>-------------------------<OPTION VALUE=-leeg-><OPTION VALUE=assessment>assessment<OPTION VALUE="ass.center">assessment center<OPTION VALUE=beoordeling>beoordeling<OPTION VALUE=betrouwbaarheid>betrouwbaarheid<OPTION VALUE=capaciteiten>capaciteiten<OPTION VALUE=ethiek>ethiek<OPTION VALUE=fairness>fairness<OPTION VALUE=functie>functie analyse<OPTION VALUE=generalisatie>generalisatie<OPTION VALUE=hrm>HRM<OPTION VALUE=interview>interview<OPTION VALUE=management>management<OPTION VALUE=manual>manual<OPTION VALUE=motivatie>motivatie<OPTION VALUE=persoonlijkheid>persoonlijkheid<OPTION VALUE=plaatsing>plaatsing<OPTION VALUE=psychometrie>psychometrie<OPTION VALUE=selectie>selectie<OPTION VALUE=statistiek>statistiek<OPTION VALUE=strategie>strategie<OPTION VALUE=tests>tests<OPTION VALUE=utiliteit>utiliteit<OPTION VALUE=validiteit>validiteit<OPTION VALUE=werving>werving</SELECT></TD></TR>", myrow[10], myrow[11], myrow[12]);
printf ("<TR><TD>Trefwoord 3</TD><TD><SELECT NAME=trefw3><OPTION VALUE=%s>%s<OPTION VALUE=%s>-------------------------<OPTION VALUE=-leeg-><OPTION VALUE=assessment>assessment<OPTION VALUE="ass.center">assessment center<OPTION VALUE=beoordeling>beoordeling<OPTION VALUE=betrouwbaarheid>betrouwbaarheid<OPTION VALUE=capaciteiten>capaciteiten<OPTION VALUE=ethiek>ethiek<OPTION VALUE=fairness>fairness<OPTION VALUE=functie>functie analyse<OPTION VALUE=generalisatie>generalisatie<OPTION VALUE=hrm>HRM<OPTION VALUE=interview>interview<OPTION VALUE=management>management<OPTION VALUE=manual>manual<OPTION VALUE=motivatie>motivatie<OPTION VALUE=persoonlijkheid>persoonlijkheid<OPTION VALUE=plaatsing>plaatsing<OPTION VALUE=psychometrie>psychometrie<OPTION VALUE=selectie>selectie<OPTION VALUE=statistiek>statistiek<OPTION VALUE=strategie>strategie<OPTION VALUE=tests>tests<OPTION VALUE=utiliteit>utiliteit<OPTION VALUE=validiteit>validiteit<OPTION VALUE=werving>werving</SELECT></TD></TR>", myrow[13], myrow[14], myrow[15]);
printf ("<TR><TD>Tijdschrift</TD><TD><INPUT TYPE=text NAME=auteur3 SIZE=2 MAXLENGTH=1 VALUE=%s></TD></TR>", myrow[16]);
printf ("<TR><TD></TD><TD>><INPUT TYPE=submit NAME=Submit VALUE=Verander></TD></TR>");
printf ("</TABLE></FORM>\n");

$row++;
}
while ($row < $numrows);
printf ("</table>\n");
pg_close($db);
?>
</body>

I tried to exclude the 16th line by adding // to it. but than I saw that also the 17th line isn't OK and the 18th!

Hope anybody knows how to fix this?

Kasper

Anon

I think it is the commas:

", myrow[0]);

I think you want:

".myrow[0]);

mharju

Hi Kasper!

First of all, You've forgotten the '$'-sign in front of the variables!

Secondly, your query is quite horrible? why can't you say:

SELECT auteur1, auteur2, auteur3, titel, jaar, bron, afl, trefw1, trefw2, trefw3, tijdschrift FROM literatuur WHERE id='$id'

If you need to reference for example "trefw1" more than once, just reference the $myrow[8] again!

🙂Mikko

mharju

No, he's using the printf()-function which is used differently from the print() or echo() -functions.

But anyhow, Kasper, you shouldn't use printf() since you don't really need special formatting. It's much slower than echo() or print!

Just do for example:
print "<something>".$myrow[1]."</something"\n";

the dots concatenate two strings, just like in perl.