problem with user/password login

[Anon]

the user enters his username ($name) and his password ($pw). usernames and passwords are stored in pw.txt.

this is the code i've written, and i don't get why it doesn't work. any help would be nice. thanks!

<?php
function redirect($URL)
{
echo "<script language='javascript'>";//
echo "function redirect(url){" ;
echo "document.location.href=url;}";
echo "redirect($URL)";
echo "</script>";
}

$pwfile = file("pw.txt");
$records = count($pwfile);
for ($i=0; $i<$records; $i++){
$line = explode( ";", $pwfile[$i] );
if(($name==$line[0])&&($pw==$line[1])){
echo "welcome, $name";
exit;
}
}
if($i=$records){
redirect("'error.php'");
exit;
}
?>

[Anon]

The single = in if($i=$records) is one problem.

This code isn't particularly efficient either. You really don't even need the explode line. You can check if $pwfile[$i] == $name . ";" . $pw or you can probably even drop the loop and use in_array($name . ";" . $pw, $pwfile)

[Anon]

Okay, I changed it so far:

$pwfile = file("pw.txt");
if(in_array('$name.";".$pw' , $pwfile)){
echo "welcome, $name";
}
else{
redirect("'error.php'");
}

Now, again, I don't know how to go on 'cause I have no idea of arrays...