String comparisons...

cpgordano

When I check:

if ($string1 == $string2)

Even if the strings are identical it will go directly to the else statement. I am trying to check to see if a name in string 1 is == to the name in string 2. I tried to use srtcmp but this only compares the length of the two to see if they are shorter, longer or the same length. Any help would be greatly apprecieted.

cordex

Have you done a var_dump of the values? That will show the exact contents and the number of characters in each string. You may have a leading or trailing whitespace (trim() it to get rid of those) that are causing this statement to evaluate untrue.

cpgordano

This is what I have now...

<BODY>
<?
function CheckUser($myusername)
{
if ($myFile = fopen("users","r"));
$ValidLogin = 0;
while (!feof($myFile))
{
$myLine = fgets($myFile,255);
trim($myusername);
trim($myLine);
print ("From Data File: $myLine<br>\n");
print ("From Username: $myusername<br>\n");

    $namefound = strstr($myLine,$myusername);
    print ("NameFound: $namefound<br>\n");

    //if (strstr($myusername,$myLine))
    if ($myusername == $myLine)
    {
            $ValidLogin = 1;
            print ("VALID!! $ValidLogin<br><br>\n");
            return $ValidLogin;
            break;
    }
    else
            print ("NOT VALID!! $ValidLogin<br><br>\n");
  }

fclose($myFile);
}

//if (($myusername=="TheWalrus" || $myusername=="Strawberry") && ($mypassword=="14kermit")) THIS LINE WORKS FINE

if (CheckUser($myusername))// && ($mypassword=="14kermit"))
{
$LoggedIn=1;
echo "Login is Secure";
}
else
{
$LoggedIn=0;
echo "Login Has Failed for ".$myusername." with ".$mypassword." ";
}
?>
</BODY>

heliumflash02

Try checking the value in both of the strings... If you know what the value should be, try doing:

if ($string1 == "Eric")
{
echo 'string1 is ok...';
}

if ($string2 == "Eric")
{
echo 'string2 is ok...';
}

or just:

echo "$string1 = $string2";

so you can visualy check.

Good luck,
Eric Filson
CIO, Web Developer
http://www.heliumflash.com

cpgordano

Thanks, but I =tried that already. If you look at my reply to Ben's help I have added my code.

cordex

The code is functional if the two values are really the same (or at least it worked for me). You need to find out that the two values are really what they appear visually to be. Have you tried var_dump()ing them? What did that return?

Anon

You have to do this to trim the strings.

$myusername = trim($myusername);
$myLine = trim($myLine);

And sequentially reading through a file isn't particularly efficient. If your file isn't too big, call file() and use in_array() instead.

cpgordano

Var_dump returned "string(24) cgiordan@simulation.com" for both the variables. In the data file and the user input variable. The output is identical.

cpgordano

File's not that big at all and never will be really. It is simply appended and a new name is added onto the end of the list and I need to check to see if a name is in that list agains the user input. I only wanted a quick and easy solution. The documentation is limited on in_array but I'll give that a shot. Thanks alot for the guidance. Please check back with me in a bit.

peterprins

Chances are that one of those strings values is coming from a form field?

<?php

function clean_data($data){
$data = trim($data);
$data = stripslashes($data);
}

$string1 = clean_data($string1);
$string2 = clean_data($string2);

// checks for a case insensitive match
// use ereg() instead of eregi() for a
// case sensitive match
if(eregi($string1,$string2)){
// code
}else{
// code
}