Whats wrong?

[Anon]

Hi,

This is a script I use to get all the images from a webpage.

<?

// this is a take text between $start and $end function.

function in_string($string, $start, $end)
{
ereg($start.".*".$end, $string, $block);
$startlen = strlen($start);
$endlen = strlen($end);
return substr($block[0], $startlen, -$endlen);
}

//This reads the $site in to a string.

$file = join('', file($site));

// now while there's a img tag then do this

while(stristr($file, "<img"))
{

//get img tag

$imgtag = in_string($file, '<img"', '">');

//get src

$imgsrc = in_string($imgtag, 'src="', '"');

//echo img

echo "<img src=\"$imgsrc\">";

//remove the img tag that has just been ripped.

$file = str_replace($imgtag, " ", $file);
}
echo "done";

?>

ok should work.

but i get :

Warning: The length of the needle must not be 0 in c:\phpdev3\www\test2.php on line 26

line 26 being $file = str_replace($imgtag, " ", $file);

i've got no idea!

thanks if you can sovle it!

[[deleted]]

Without being sarcastic, this really sounds too obvious...

"The length of the needle must not be 0"

Looks like $imgtag is empty.

[Anon]

yes I know but why?

I've tried running it with a site and it doesn't work.

[alcapone]

what is it doing anyway?

[Anon]

$imgtag has nothing in it. Are you sure that $file isnt empty either? If its not, then are sure there is an <img> tag?

[[deleted]]

Probably because your in_string() function does do what you want it to do.
What do you want it to do anyway?

[Anon]

Ok, what the script is trying to do is get the src from the img tags from a site.

It's for a image search engine.

[[deleted]]

I meant, what do you want to in_string() to do.

But anyway, you probably need to check the in_string() function because it appears that that is giving the problems.