Can you spot the mistake?

[Anon]

The following code rotates 2 web pages, so that visitor 1 will see index0.htm, visitor 2 will see index1.htm, visitor 3 see's index0.htm and so on. To avoid a visitor seeing a different page by clicking refresh or some other means, it sets a cookie with a value of 0 or 1.

The page seems to work fine - almost. There seems to be slighly more calls to index1.htm than index0.htm. And I can't work out why.

Any suggestions?

The code below is stored in index.php.

Thanks,

Jon

<?php
//Simple PHP headline swapper

//Check for cookie
$ICCTestCode = $HTTP_COOKIE_VARS["ICCTestCode"];
if ($ICCTestCode && ($ICCTestCode != "")) {
include("index".$ICCTestCode.".htm");
} else {

if (file_exists('count.inc'))
{
//if file exists..read the last supplied file.
$fil = fopen('count.inc', 'r');
$dat = fread($fil, filesize('count.inc'));
fclose($fil);
}
else
{
//if it doesnt exist. create one.
// in ur code , if file doesnt exist, it wont display any headers. i have corrected it here.
$fil = fopen('count.inc', 'w');
fwrite($fil, 0);
fclose($fil);
$dat = 0;
}

//Set cookie

setcookie("ICCTestCode", $dat, time()+345600);

//using include to display the appropriate page:

$filename = 'index'.$dat.'.htm';
include("$filename");

// my approach for rewinding value of dat..
if($dat > 0) {
    $dat = 0;

}
else
{
$dat++;
}

//now write in the new value...
$fil = fopen('count.inc', 'w'); 
fwrite($fil, $dat); 
fclose($fil);

}
?>

[junebug]

is there a reason that you are doing it this way? this seems very resource intensive. an easier might be to use a random number to determine which page to use. and if you want to really go all out, you could save all the pages in one directory, read the directory into an array, shuffle the array, then get the size of the array and use that number for the confines of a random number to use as the key to select a file out of the array. just some thoughts. but reading and writing to a text file each time is a bit much and will cause the script to slow. would this way work?

reference:

http://www.php.net/mt-rand
http://www.php.net/manual/en/ref.dir.php
http://www.php.net/shuffle

[Anon]

I don't want to randomise as I am calculating the conversion ratio of visitors to sales for each page. I use webtrends to get the total number of website visitors and just divide by 2. It is easier for me this way.

Jon

[Anon]

I don't see the mistake. I got really bored, so I wrote the following for you :o) uses sessions.

<?php
session_start();
if(isset($HTTP_SESSION_VARS['view'])) {
header("Location: index{$HTTP_SESSION_VARS['view']}.htm");
setLastView($HTTP_SESSION_VARS['view']);
}
else {
$view = getLastView();
setLastView(!$view);
session_register("view");
header("Location: index{$view}.htm");
}

function setLastView($view) {
$fp = @fopen("last.dat", "w");
@fwrite($fp, $view);
@fclose($fp);
}

function getLastView() {
if($fp = @fopen("last.dat", "r") {
$n = fread("last.dat", "r");
fclose($fp);
return($n);
}
else {
return(mt_rand(0, 1));
}
}

?>

[Anon]

if ($ICCTestCode && ($ICCTestCode != "")) {
include("index".$ICCTestCode.".htm");
} else {

that seems strange to me... im not sure if it is the problem but it might be an error.

[Anon]

Thanks! But I need to have a rotating page so that the visitor only see's one page. i.e. if they come back 3 days later, they see the same page as they originally saw.

Also, it can't be random. It must be index0 and then index1.

Jon