header already sent

Anon

I am having a problem with the headers already being sent from my register.php and me trying to redirect to another page if the username and password are approved. Otherwise, the person could register for numerous passwords. Also, I would like to have the information that was initial sent to register.php as hidden no longer available once a username and password has been registered and they have been redirected. I am including a snippet of the code from my user.php and the register.php.

Any help would be gratly appreciated.

user.php

		$sql="SELECT * FROM user WHERE user_name='$user_name'";
		$result=db_query($sql);
		if ($result && db_numrows($result) > 0) {
			$feedback .=  ' ERROR - USER NAME EXISTS ';
			return false;
		} else {
			//create a new hash to insert into the db and the confirmation email
			$hash=md5($email.$hidden_hash_var);
			$sql="INSERT INTO user (user_name,real_name,password,email,remote_addr,confirm_hash,is_confirmed,streetaddress,streetaddress2,city,state,zipcode,shiptophone,szOrderNumber,accountnumber,month,year,transactionamount,donate_amount_rb) ".
				"VALUES ('$donate_amount_rb','$streetaddress','$streetaddress2','$city','$state','$zipcode','$shiptophone','$szOrderNumber','$accountnumber','$month','$year','$transactionamount','$user_name','$real_name','". md5($password1) ."','$email','$GLOBALS[REMOTE_ADDR]','$hash','0')";
			$result=db_query($sql);
			if (!$result) {
				$feedback .= ' ERROR - '.db_error();
				return false;
			} else {
				//send the confirm email
				user_send_confirm_email($email,$hash);
				//$feedback .= ' Successfully Registered. You Should Have a Confirmation Email Waiting ';
				//$feedback .= $success;
				return true;

			}
		}
	} else {
		$feedback .=  ' Account Name or Password Invalid ';
		return false;
	}
} else {
	$feedback .=  ' ERROR - Must Fill In User Name, Matching Passwords, And Provide Valid Email Address ';
	return false;
}

}

<?php

include($DOCUMENT_ROOT.'/include/database.php');
include($DOCUMENT_ROOT.'/include/pre.php');
include($DOCUMENT_ROOT.'/include/user.php');

if (user_isloggedin()) {
user_logout();
$user_name='';
}

if ($submit) {
user_register($user_name,$password1,$password2,$email,$real_name,$streetaddress,$streetaddress2,$city,$state,$zipcode,$shiptophone,$szOrderNumber,$accountnumber,$month,$year,$transactionamount,donate_amount_rb);
}

if ($success) {
header("Location: http://www.whatever.cc/success.html");
exit;
}

site_header('Register With Charity Support Group');

if ($feedback) {
echo '<FONT COLOR="RED"><H2>'.$feedback.'</H2></FONT>';
}

Anon

Where does it say that the headers were already sent? Make sure you have NOTHING sent to the browser BEFORE you send the email or headers. I'm not too sure whether or not the email being sent has anything to do with it, but emails send headers....

I had this problem earlier, but remember'd I had print()'d something before I did the header:location. Make sure you dont have any printing to the browser in your includes.

Also, Are you relaying them to the site before your site_header gets processed?

Good luck,
Craig

Anon

I forgot to add in the header("Location: http://www.whatever.cc/success.html");
exit;
I insert this just before the return true; of the user.php

Anon

Craig,
What I want to have happen is this. The person signs up for membership and gives credit card info. Once they have completed the credit card approval the info they submitted (name, address, etc...) is sent [hidden input] to register.php. They are asked to enter a username and password. If there is a problem like not enough characters or the username is already taken then the user.php defines the feedback message. The register.php then displays this message across the top of the page in red and they can try another username and or password. If the username and password are accepted then I would like to have them forwarded to a page telling them to check their email. I can have it display a message telling them to check their email, but they are still on the password page and can register for several if they wanted. So the redirect seems to be the way to go. If It would be great if I could make sure that the hidden information is no longer available if they go back in their browser. I posted a reply showing the redirect I inserted into the user.php code.

Let me know what you think.

Thanks,
Chris