Split Phone Numbers??

Anon

OK, I've got a database full of user-entered phone numbers with slightly different formats, like this:

(555)222-2222
OR
1-555-555-5555
OR
555.555.5555

... depending on how the user entered it in.

Now I want to take each string, such as:

$phone=(555) 347-2899;

And split it up into the three components of the number
$area_code=555;
$city_code=347;
$local_number=2899;

...and I want to be able to do this regardless of () or spaces or - or "." which the user may have entered. Since all of the numbers are in slightly different formats, I'm baffled... I don't even know where to begin. Since some include the "1" at the beginning of the number, and some don't I'm guessing I need to start at the back and work my way forwards...?? somehow.

Any help would be greatly appreciated.

Regards,

Mark H.

kparker

Are these all NANA numbers? (North American Numbering Authority) As found in the US, Canada, and a few other places? If so, it's easy. If not, you're in a world of hurt (pardon the pun!)

Assuming that they are, here's an easy way to reformat them:

Remove all non-digits from the string.
If the string is exactly 11 digits and the first digit is '1', remove the first digit.
If the string doesn't measure exactly 10 or 7 digits, toss it--it's defective in some way.
If it's 7 digits long, it's probably just missing the area code. Whether you keep these or not is up to you.
Otherwise, it's 10 digits, so it's just a matter of using substr() to pick apart the pieces and reformat it to your specs.

khaine

the code could look something like.

<?php

$pnum="(123) 456-789";
$pnum=str_replace("(", "", $pnum);
$pnum=str_replace(")", "", $pnum);
$pnum=str_replace(" ", "", $pnum);
$pnum=str_replace("-", "", $pnum);

if ( strlen($pnum)== 10 )
{
$bit1=subsr($pnum, 0, 3);
$bit2=subsr($pnum, 3, 3);
$bit3=subsr($pnum, 6);
}
if ( strlen($pnum)== 7 )
{
$bit1="000";
$bit2=subsr($pnum, 0, 3);
$bit3=subsr($pnum, 3);
}
?>

Mark.

znouza

you should shorten your code
<?
$number="(123) 1233-234";

remove all but digits

$number = ereg_replace("[^{0-9]","",$number);}

if strlen=7, add leading zeros

$number=(strlen($number)==7)?$number="000$number":$number;

and split

if (strlen($number)==10)
{
ereg("(.{3})(.{3})(.*)",$number,$bit);
}

you should access that values aka
$bit[1] = first 3 numbers
$bit[2] = second 3 numbers
$bit[3] = the rest
?>

znouza

sorry, a mistake:

$number=(strlen($number)==7)?$number="000$number":$number;

should be

$number=(strlen($number)==7)?"000$number":$number;

khaine

I thought about using ereg but I never could get it to work properly. I will learn it someday.

Mark.

kparker

Actually, your real mistake was using the ternary operator when a plain old if would work just as well, and be much clearer. Whoever said the shortest possible code was the best--outside of farcical events such as the "Obfuscated C Code Contest", that is? Make it correct and make it clear. Whoever comes after you to maintain the code (or even yourself, 3 months later when you've forgotten all about it) will bless you!

kparker

Actually, why wait? Tom's example of using ereg works perfectly, and the explanation actually explains exactly what it does! So let it be your very first working regex, and learn more about them later.

Furthermore, besides being more compact than a series of calls to str_replace, it has a very beautiful feature: since it specifies the characters you want to keep (the set of which won't change) rather than the characters to get rid of, it automatically works for any other punctuation character you haven't thought of, e.g. 123.456.7890, 100/200/1234, etc.

znouza

I like to use that construction I've write the code. It;s much more easier to read within a lot of code - when you want your code has good readability, you should ever use what's the best to you.

classic if
if (something)
{
do_if_true;
} else {
do_if_false;
}

my code (only variable assigment)
$variable=(condition) ? value_if_true: value_if_false;

and if you know perl and look at some of it's code...
$variable=value if (condition); is ordinary example. You HAVE THE RIGHT TO CHOOSE.

Anon

Hello all,

I know this is an old thread but I could not believe what I read. Your_real_mistake was using the Ternary Operator? ARE YOU KIDDING ME? To each there own, but frankly reading a ternary statement is really not all too difficult even when they are embeded. Perhaps you should stick with Visual basic. Use those pretty gui enviornments for your coding. HOLY CRAP.