Foreach Problem

mrlk01

Hi there,

I am new to PHP and have a problem. A pice of code works on my own test server but not when I upload to my webspace.

This code try's to read a file containing preformatted links, this file index's articles submitted by users. I want to extract the first 5 links from the file and reformat them for the main page (remove list item, bring on to one line etc).

this is the code

#open file
$myfile = "/PATH/TO/MYDAT/FILE/data.dat";

#number of files wanted plus one 2 gives 3
$maxlatest =4;

# Article links file
if(file_exists($myfile)){
	$fh = fopen($myfile, "r");
	$old_news = fread($fh, filesize($myfile));
	fclose($fh);
}


# get first five article links
$articles = explode("</li>", $old_news);

$articles = str_replace("<li>","",$articles);
$articles = str_replace("<br />"," by ",$articles);
$articles = str_replace("2001</span>","2001</span><br />",$articles);

$i=0;
foreach ($articles as $article){
	if(count($articles)>$i){
		if($maxlatest >= $i++){
			print $article;
		}
	}
}

?>
----end code

The file it reads contains links as list items...

<li><a href="Sep-06-213155.php">Formatting iNdex Page</a> Mike L 6th September 2001</li>
<li><a href="Sep-06-213155.php">Formatting iNdex Page22</a> Mi 6th September 2001</li>
<li>

Each LI is on it's own line.

It works fine on my test server but I get a warning on my ISP's server ..

warning: invalid argument supplied in foreach() statement in /PATH/TO/SCRIPT.php on Line 25

Line 25 is the start of the foreach.

I have used this script to learn but am very confused why it does not work. I also think that maybe there is another way to do this?

I have it in my head that I am not using an array properly and this is why the foreach fails, but it does work on my linux box fine.

the only other thing I can think of is a version problem, my ISP has installed PHPver 4.0.4, mine is 4.0.5

Any help or advice would be greatly appreciated,

Best wishes

Mike

Anon

I don't think it relies to the PHP Version.

1.) Check whether the file has been opened
with something like:

$fh = fopen($myfile, "r")
or die("Cannot open the file");

2.) make a

echo "<pre>";
echo var_dump ($articles);
echo "</pre>";

then you can see the contecnt of the array.

mrlk01

Hi Linux God,

Ok I tried that, the file is opening fine.

I am still getting a 'Invalid argument supplied for foreacg() on Line 28'. Line 28 is the start of the foreach().

The var dump says:

string[5] "Array".

I pressume this means that the array is nt working?

This wrks on my own machine (linux, apache php4.04) but not on my ISP's machine, wierd.

I have been checking the sytax against books and online examples - I just can nt see anything wrong.

Maybe it's time for new specticals!!

Cheers for reply,
Mike