MySQL UPDATE & mysql_affected_rows

[Anon]

Hi!
I'm using this query:

	$sql = mysql_query("UPDATE players SET name = '$f_name', surname = '$f_surname' WHERE player_id = '$pid'",$db);
	$result = mysql_query($sql,$db);

	if (mysql_affected_rows($db) != -1)
	{
		echo "error!";	
	}
	else
	{
		echo "Procedure completed succesfully!";
	}

	It can happen, that only one attribute is changed (either name or surname), or both.
	mysql_affected_rows($db) always returns -1. 

	Help? Is there a better way to check if the DB action completed succesfully?

Thanks!

[greggory]

mysql_affected_rows returns -1 if it fails.

You have to replace your != with a ==

[Anon]

Yes, I know that. But this is not the problem.
The problem is that mysql_affected_rows return -1 also in the case if an update is made (name is changed, surname isn't or the other way...)

[Anon]

I messed up the if sentence.

if (mysql_affected_rows($db) == -1)
{
echo "error!";
}
else
{
echo "Procedure completed succesfully!";
}

But this wasn't the main question.
Sorry 😉

[greggory]

In this case, I don't know.
I use mysql like you, but I know that db operations are not 'atomic' so weird things can happen.
Maybe you'd better contact directly the mySql devel team 😛

[Anon]

$sql = mysql_query("UPDATE players SET name = '$f_name', surname = '$f_surname' WHERE player_id = '$pid'",$db);

this should be:

$sql = UPDATE players SET name = '$f_name', surname = '$f_surname' WHERE player_id = '$pid'";

dOh! 😉
It's now working properly...