function problems

[jesus_hairdo]

i've come up with the following function. what it is supposed to do is draw a table with 3 columns & 5 rows. In each cell there should be a tickbox. what it does is takes values in for each box (monday_am, monday_pm etc. goes through each one, if the value = 1 then the box should be tick if not the box isn't ticked.
What I am actually getting is this
"<table width="0" cellspacing="0" cellpadding="0">
<tr><td></td><td><input type="checkbox" name="" value="" checked></td></tr>
</table>" basically 1 box in a table. Any ideas, please ??

<?
function dodays($monday_am,$monday_pm, $moday_eve, $tuesday_am, $tuesday_pm, $tuesday_eve, $wednesday_am, $wednesday_pm, $wednesday_eve, $thursday_am, $thursday_pm, $thursday_eve, $friday_am, $friday_pm, $friday_eve, $other)
{
?>
<table width="0" cellspacing="0" cellpadding="0">
<?
/ setting up variables /
$numcols = 3 ;
$numdays = 5 ;
$daylist = array( "monday", "tuesday", "wednesday", "thursday", "friday") ;
$boxlist = array( "am", "pm", "eve") ;
for ($day = 0 ; $day <= $numdays ; $day++ ) ;
{
print "<tr>" ;
$fullday = $daylist[$day] ;
print "<td>$fullday</td>" ;

  /* draw the boxes now */

  for ($i = 0 ; $i <= $numcols ; $i++ );
        {
        $boxtime = $boxlist[$i] ;
        $box = "$fullday_$boxtime" ;

        /* check to see if box needs ticking */

        if ($$box == "1")
              {
              $button = "<input type=\"checkbox\" name=\"$box\" value=\"$boxtime\" checked>";
              }
        else
              {
              $button = "<input type=\"checkbox\" name=\"$box\" value=\"$boxtime\">";
              }
        print "<td>$button</td>" ;
        }
  print "</tr>" ;
  }

?>

</table>
<?
}
?>

[Anon]

Besides this ...intresting... code, you're not putting the <input> in a cell. they've got to be between <td></td>

Also you can't create variable variable names. ie: you won't be able to get $monday_am etc

Mark

[jesus_hairdo]

I'm sorry mark but i have to disagree on both points. You can create variable variables, because i have used a similar process before to great success.
Also the inputs ARE in a cell. Both in my code and in the resulting html, just without a value for $fullday and only 1 row.

[Anon]

Heh, lets look at the code...

                   <? 
                   function dodays($monday_am,$monday_pm, $moday_eve, $tuesday_am, $tuesday_pm, $tuesday_eve,
                   $wednesday_am, $wednesday_pm, $wednesday_eve, $thursday_am, $thursday_pm, $thursday_eve,
                   $friday_am, $friday_pm, $friday_eve, $other) 
                   { 
                   ?> 
                   <table width="0" cellspacing="0" cellpadding="0"> 
                   <? 
                   /* setting up variables */ 
                   $numcols = 3 ; 
                   $numdays = 5 ; 
                   $daylist = array( "monday", "tuesday", "wednesday", "thursday", "friday") ; 
                   $boxlist = array( "am", "pm", "eve") ; 
                   for ($day = 0 ; $day <= $numdays ; $day++ ) ; 
                   { 
                   print "<tr>" ; 
                   $fullday = $daylist[$day] ; 

//Cell 1
print "<td>$fullday</td>" ;

                   /* draw the boxes now */ 

/* Cell 2 should be in here?

                   for ($i = 0 ; $i <= $numcols ; $i++ ); 
                   { 
                   $boxtime = $boxlist[$i] ; 
                   $box = "$fullday_$boxtime" ; 

*/

                   /* check to see if box needs ticking */ 

                   if ($$box == "1") 
                   { 
                   $button = "<input type=\"checkbox\" name=\"$box\" value=\"$boxtime\" checked>"; 
                   } 
                   else 
                   { 
                   $button = "<input type=\"checkbox\" name=\"$box\" value=\"$boxtime\">"; 
                   } 

//Cell 3
print "<td>$button</td>" ;
}
print "</tr>" ;
}
?>

                   </table> 
                   <? 
                   } 
                   ?>

As for variable variables, yes you can create them. You're trying to create a variable name variable which is not possible.... either that or you've got needless $day_$time variables being passed to the function as they aren't used in the code.

Mark

[jesus_hairdo]

I don't quite understand, whats the different between a variable variable and a variable named variable?
The cell 2 that you have put in is unneccessary as there is no output there. only 'cell 1' and 'cell 3' actually output anything.
What i don't understanding is that it only draws 1 box for the first row and that $fullday and $boxlist seems to not be getting a value