Accessing Array with Loop

Anon

I was hoping someone might be able to point this out to me, I am sure that it is fairly obvious but for some reason it just wont click.

What i am doing is searching a url and pumping the data I am looking for into an array. The only problem is I am only getting 1 of the results when there should be 10-12 results.

the code in question:

$contents = fread($fp, 5980);
fclose($fp);

// Find the cost and output it
$pattern = \"(\\\$[0-9 ]+\\.[0-9]+)\";
if(eregi($pattern, $contents, $cost)){
for($i=0; $i = count($cost); $i++){

echo \"$cost[$i]\";

} else {
echo \"Information currently Unavailable.<br>
If problem persists please contact the administrator.\";
exit();
}

Is it a problem in my loop?

Any help appreciated.

John

lawnmowerman

Well, the thing that really pops out in my mind is:

$i = count($cost)

should be:

$i <= count($cost)

With the =, the loop will only run if there are 0 values in the array (since $i is set to 0).

You need the <= so the loop will execute for all values from 0 to count($cost)

-Rich

Anon

(1) There's an error in the loop test: you have '=' (assignment!) when clearly you should have '<'.

(2) There's a missing closing brace before the 'else'.

(3) Since there's no alpha chars in the pattern to match, you don't need eregi(), plain ereg() will do.

(4) Finally, ereg() doesn't work the way you apparently think it does: what shows up in the results array is [0] contains the entire string, [1] contains the results of matching the first parenthesized expression, [2] the second, and so on. In any case, each parenthesized sub-pattern will match only one substring of the target string.

All is not lost, however--the PCRE functions will do what you want:

if ($n = preg_match_all( '/\$[0-9]+.[0-9]+/', $contents, $cost ))
  {
  for ($i = 0; $i < $n; $i++ )
    echo $cost[0][$i] . '<br>';
  }
...

Anon

You guys rock. I knew that there was something definitely wrong with the way I was going about it.

Thanks again guys its working perfectly now.

John