error - syntax or otherwise? - PHPBuilder Forums

error - syntax or otherwise?

Anon

I keep getting this error:

Parse error: parse error, expecting ','' or';'' in output_fns.php on line
170

from the function below. This is the line generating the error:

echo <img src=\"$color["pic_thumbnail"]\" width=100 height=75>;

function display_color_details($color)
{
// display all details about this book
if (is_array($color))
{
echo "<table><tr>";
echo "<td><table>";
echo "<tr><td>";
echo <img src=\".($color["pic_thumbnail"])\" width=100 height=75>;
echo "</td></tr>";
echo "<tr><td>";
echo $color["color_name"];
echo $color["color_num"];

}
else
echo "The details cannot be displayed at this time.";
echo "<hr>";
}

I'm not sure what to escape in the line. But I think there may be a problem with the line otherwise.

Any suggestions?

Thanks,

John

ashbai

echo <img src=\".($color["pic_thumbnail"])\" width=100 height=75>;

thats ur problem :
u forget to insert the " after echo ... and in the end of the same line ...

and there is no need for the " inside the array [] ..
like :

$result[first_name] ...

i hope thats okkay ..

Anon

thanks! definitely part of the problem, but not everything, unfortunately.

Now I get two more errors:

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in
output_fns.php on line 170

Parse error: parse error, expecting ','' or';'' in output_fns.php on line
170

from this line:

echo "<img src="\$color[pic_thumbnail]\" width=100 height=75>";

in this function

function discplay_color_details($color)
{
// display all colors
if (is_array($color))
{
echo "<table><tr>";
echo "<td><table>";
echo "<tr><td>";
echo "<img src="\$color[pic_thumbnail]\" width=100 height=75>";
echo "</td></tr>";
echo "<tr><td>";
echo $color["color_name"];
echo $color["color_num"];

}
else
echo "The details of this book cannot be displayed at this time.";
echo "<hr>";
}

any other thoughts?

Thanks

amcgrath

Change this: echo "<img src="\$color[pic_thumbnail]\" width=100 height=75>";

to this:
echo '<img src="\$color[pic_thumbnail]\" width=100 height=75>';

Anon

Great, it worked! thanks Allen.

this function:

function display_color_details($color)
{
// display all colors
if (is_array($color))
{
echo "<table><tr>";
echo "<td><table>";
echo "<tr><td>";
echo '<img src="\$color[pic_thumbnail]\" width=100 height=75>';
echo "</td></tr>";
echo "<tr><td>";
echo $color["color_name"];
echo $color["color_num"];

}
else
echo "The details cannot be displayed at this time.";
echo "<hr>";
}

is supposed to list an array of images related to a "brand". There could be up to 50 images. I don't want the images to stack vertically as they would in the above function, I'd prefer them to be <td>'s. Maybe 6 <td>'s per <tr> then return a new row. I don't know how to limit the loop to a fixed number of <td>'s and then begin
</tr>
<tr>
<td>

Any advice?

Thanks in advance,

John

amcgrath

Ok, first I don't see where you are looping through a list of images. All I see is

echo '<img src="\$color[pic_thumbnail]\" width=100 height=75>';

If you want to display a list of images 6 across, then in your image display loop (which I don't see above), do something like this:

echo "<tr>";
echo "<td>";
$tick = 0;
while(list(,$v) = @each(images_i_dont_see)) {
echo "<img src=\"$v\">";
echo "</td>";
if (!++$tick % 6) { // six table cells
echo "</tr><tr>";
}
}
echo "</table>";

Anon

I'll give this a try. Maybe I'm not communicating what I'm doing properly (I'm a bit new to this).

I have two functions that will get the colors and display:

function get_colors($brand_id)
{
// query database for the books in a category
if (!$brand_id || $brand_id=="")
return false;

$conn = db_connect();
$query = "select * from color where brand_id='$brand_id'";
$result = @($query);
if (!$result)
return false;
$num_books = @mysql_num_rows($result);
if ($num_books ==0)
return false;
$result = db_result_to_array($result);
return $result;
}

and

}
else
echo "The details cannot be displayed at this time.";
echo "<hr>";
}

And they are called in a a show_color.php by

// get colors out of db
$color = get_color_details($brand_id);
display_color_details($color);

The $color array is whatever colors are associated to a brand.

There could be 1 to 50 colors per brand.

John

Anon

Can i put that directly in the display_color($color) function?

function display_color_details($color)
{
// display all details about this book
if (is_array($color))
{
echo "<table><tr>";
echo "<tr>";
echo "<td>";
$tick = 0;
while(list(,$v) = @each($color[pic_thumbnail])) {
echo "<img src=\"$v\">";
echo "</td>";
if (!++$tick % 6) { // six table cells
echo "</tr><tr>";
}
}
echo "</table>";

}
else
echo "The details of this book cannot be displayed at this time.";
echo "<hr>";
}

amcgrath

It should, I don't see why not.

ashbai

echo "<img src="\$color[pic_thumbnail]\" width=100 height=75>";

it has to be:

echo ("<img src='".$color[pic_thumbnail]."' width=100 height=75>";

try it ..