file upload madness

[Anon]

Help me!
I'm trying to use a file upload script on my site.Here is a part of the script I'm using:

$filename = substr(strrchr($file,"\ "),1);

if(!copy($file,$path.$filename))
{
echo "<font color='red'><center>".$message["uncomplete"]."</font></center>";
}
else
{
echo "<font color='red'><center>".$message["complete"]."</font></center>";
}

echo "
<form method='post' enctype='multipart/form-data'action='upload.php' >
<table frame=box rules=none border=0 cellpadding=2 cellspacing=0 align='center'>
<tr><td>".$message["uploadtxt"]."<td><input type='file' name='userfile'>
<tr><td><td><input type='submit' value='".$message["uploadbutton"]."' name='upload'>
</table>
</form>

The problem is that after you pick a file, the form submits an empty string in $file!!! What am I doing wrong?

[Anon]

I'm sorry the form part was wrong, but the problem remains the same!

<form method='post' enctype='multipart/form-data'action='upload.php' >
<table frame=box rules=none border=0 cellpadding=2 cellspacing=0 align='center'>
<tr><td>".$message["uploadtxt"]."<td><input type='file' name='file'>
<tr><td><td><input type='submit' value='".$message["uploadbutton"]."' name='upload'>
</table>
</form>

[amcgrath]

I really can't figure out why you're doing this:
$filename = substr(strrchr($file,"\ "),1);

Here's what I do, it works fine (I'm uploading images):

     if ($image_file <> "none" && !empty($image_file)) {
       chdir($erp["img_upload_path"]);
       $dir = opendir(".");
       if ($image_file_type == "image/jpeg") $ext = ".jpg";
       elseif($image_file_type == "image/pjpeg") $ext = ".jpg";
       elseif ($image_file_type == "image/gif") $ext = ".gif";
       elseif ($image_file_type == "image/png") $ext = ".png";
       $new_name = "SPEC_" . $spec_id . $ext;
       copy($image_file, $new_name);
       unlink($image_file);
     } else {
       $new_name = "Not Available";
     }

[Anon]

Thanks, but I figured it out. If your server is running PHP4, there is a simpler way of getting the file name:
$filename=$HTTP_POST_FILES['userfile']['name']
This is a global array introduced in PHP4, which stores only the file name with it's extension.

and then you copy($file,$path/$filename)