Variable update

[jc94062]

I'm trying to set up a multiple delete feature for a private messaging system but am having a problem with the update feature.

I need to have the output of ${"delmsg".$i} (integer) put as the msg_id into the update query as below...

$view_delete_query = "UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id='${"delmsg".$i}'";

However, due to the single quotes - msg_id=''
it reads it literally as ${"delmsg".$i} and not the actual output.

I can get around this by doing "${"delmsg".$i}" but that of course gives an error. I've tried several things, including '\"${"delmsg".$i}\"' but just can't seem to get it to work.

I have to use a "complex" variable such as that due to the checkbox system.
Each message has a checkbox with name delmsg$cnt (where $cnt is an autoincremental counter) and the value is the $msg_id of that message.

Any advice on how to sort this would be much appreciated!

[vsego]

$deltemp = ${"delmsg".$i};
$view_delete_query = "UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id='$deltemp'";

or

$view_delete_query = "UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id='".${"delmsg".$i}."'";

[jc94062]

I'd tried the top one already but gave it another shot, no luck.

Tried the bottom as well, still no luck, I get the message that comes out as a result of the query being executed "Message deleted" but its still there when I go back :-(

[vsego]

I have a feeling that your problem lies somewhere else. But, just to make sure, add (after $view_delete_query = ...😉

echo "\"".$view_delete_query."\"<br>\n";

If it holds the right value, you should debug your database. If not... errr... we have a problem. :-) In that case, check the value in $deltemp (or ${"delmsg".$i} - whichever you used). Also, make sure you haven't embeded variables in single quote (i.e. ${'delmsg$i'}). Also, check the names and values of your checkboxes (in the form). Are all variables properly sent?

If you still don't find the problem, consider posting all the relevant code here (form that sent this, all the lines using delmsg$i variables,...).

Good luck!

[jc94062]

Yep, I've tried that before and its fine!

It just hates the single quotes, I've echoed it with the single quotes and its trying to find a value like ${"delmsg".$i} in the msg_id field, obviously it can't! For a start its not a mediumint.

Heres the relevant code, because this is driving me mad! (Sorry it took so long to reply, my ISP decided to go down for several hours)

I've simplified the code, as most of the coding is buried in lots of html.

$cnt=0;
//while loop
//table start
echo "<form action=\"$PHP_SELF\" action=post>";
//table output...
<a href=\"$PHP_SELF?msg_id=$msg_id&type=view&delete=yes\"><font color='red'>(Delete)&nbsp;<input type=\"checkbox\" name=\"delmsg$cnt\" value=\"$msg_id\"></font>
//end table
//update query to show the message as viewed
$cnt++;
echo "<input type=\"hidden\" name=\"nummsg\" value=\"$cnt\">";
echo "<input type=\"submit\" name=\"multipledelete\" value=\"Delete Multiple Messages\"><br>";

if ($multipledelete) {
$i=0;
while($i<=$nummsg) {
$view_delete_query = "UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id='".${"delmsg".$i}."'";
$i++;
}
$view_delete = mysql_query($view_delete_query);
if ($view_delete) {
echo "Messages deleted";
exit;
} //end view_delete
} //end multiple delete

If I do something like

echo "${"delmsg".$i}" then I get the output 58Message Deleted, assuming the ID of the message I select is 58, however, it doesn't
update.

If I put in echo "\"".$view_delete_query."\"<br>\n"; after the update line I get...

"UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id=''"
"UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id=''"
"UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id=''"
"UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id='58'"
"UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id=''"
"UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id=''"
Messages deleted

Again, nothing happens...

If that code is too vague I can post it all in more detail.

[vsego]

while($i<=$nummsg) {
$view_delete_query = "UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id='".${"delmsg".$i}."'";
$i++;
}
$view_delete = mysql_query($view_delete_query);

First, you are setting $view_delete $nummsg times and AFTER that you are using $view_delete. This is obviously the last version of $view_delete, so the only SQL being executed is the last one (with empty ${"delmsg$i"} if the last checkbox was not checked). Consider this code:

$delcnt = 0;
while($i<=$nummsg) {
if (isset(${"delmsg".$i})) {
$view_delete_query = "UPDATE egomessenger SET recipient_delete='Y' WHERE msg_id='".${"delmsg".$i}."'";
if (mysql_query($view_delete_query)) $delcnt++;
}
$i++;
}
echo "$delcnt messages deleted.";

[jc94062]

Thanks very much, it works great now!