Uploading Files

Anon

After trying unsuccessfuly for hours to upload a file with my own script I tried copying a script from a book. It still gave me the same problem. After I hit submit on the form, the action script is is set to check to make sure the file is larger than 0 bytes. It never is!! Furthermore, to help me see what is going on I had it echo the $userfile variable to the screen. It lists the local location of the file (C:\MyFiles\mo_big2.jpg) as being on my local hard drive. I thought the $userfile_name name variable was supposed to contain the files original path.(i.e. C:\MyFiles\mo_big2.jpg), but when I echo $userfile_name to the screen it is just an empty string. Does anyone have any Ideas?

amcgrath

It would help if you actually included the code you're using....

Anon

<?
// file_upload.php
$archive_dir = "/www";
function upload_form() {
global $PHP_SELF;
?>

<FORM METHOD="POST" enctype="MULTIPART/FROM-DATA" ACTION="<? echo $PHP_SELF ?>">
<input type="hidden" name="action" value="upload">
Upload file!
<INPUT TYPE="FILE" NAME="userfile" >
<INPUT TYPE="SUBMIT" NAME="SUBMIT" VALUE="UPLOAD">
</FORM>

<?
}

function upload_file() {
global $userfile, $userfile_name, $userfile_size, $userfile_type, $archive_dir, $WINDIR;
echo "$userfile";
if(isset($WINDIR)) $userfile = str_replace("\\","\", $userfile);
$userfile = $HTTP_POST_FILES['userfile']['tmp_name'];
$filename = basename($userfile_name);

if($userfile_size <= 0) die ("$filename is empty.");

if(!@copy($userfile, "$archive_dir/$filename"))
	die("Can't copy $userfile_name to $filename.");

echo "$filename has been successfully uploaded.<br>";
}
?>

<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

amcgrath

Change this: enctype="MULTIPART/FROM-DATA"
To this: enctype="MULTIPART/FORM-DATA" ...

vsego

Excuse my blindness, but what's the difference?

amcgrath

form was misspelled.

Anon

I'm in the same spot as Joey. My code is from the PHP documentation, and is contained in two php files - the first gathering user input, and the second accomplishing the upload to the server. The one difference is that my server is Linux RH v 7, with PHP v 4.0.4pL1. Following are the pertinent pieces of code.

File # 1 - User selects the files:

<?php
// selectfiles.php

echo ("<FORM ENCTYPE=\"multipart/form-data\" ACTION=\"/uploadfiles.php\" METHOD=POST>
<INPUT TYPE=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"10000000\">
Send this file: <INPUT NAME=\"userfile[0]\" TYPE=\"file\"><br>
Send this file: <INPUT NAME=\"userfile[1]\" TYPE=\"file\"><br>
<INPUT TYPE=\"submit\" VALUE=\"Send File\">
</FORM>");
?>

File # 2 - Upload the files:

<?php
// uploadfiles.php

for ($x = 0; $x < count($userfile_name); $x++) {

 if (is_uploaded_file($userfile_name[$x])) {

    copy($userfile_name[$x], "/htdocs/uploads");

 } else {

    echo "Failed to load file # " . $x . " -- " . $userfile_name[$x];

 }

}

Values are passed from selectfiles.php to uploadfiles.php for $userfile_name[] and $userfile_type[]. The value of $userfile_size[] is set to -0-.

Adding "print_r($HTTP_POST_FILES)" to uploadfiles.php returns values consistent with the above.

Thanks for the help.

Craig Cooper

vsego

Hats down! How did you notice that...

cordex

I had problems when I first created my upload script too.

It worked when running from my secured development directory (could upload anywhere on the site) but when running from a production directory, it stopped working. I realized that when I logged into the development directory, the PHP program was inheriting the administrative permissions and was therefore allowed to upload elsewhere. Since there was no login for the production directory, it was only allowed guest permissions. I fixed this by changing the permissions on my target directory to allow a guest to write to it. Be careful, though, this can be very dangerous!

-Ben

amcgrath

Well, most problems are usually minor oversights, always look for the easiest solution, cuz normally that's gonna be the right one 😉