creating and reading a file

Anon

what have a done wrong? I have a form that posts the $artist and $title so that's where those variables come from. unfortunately, it's not posting the $artist and $title, it's just leaving it empty and only displaying "Songs to Download:"

<?
$filename = "list.txt";
$newstring = "$artist - $title\n";
$myfile = @fopen($filename, "w+") or die("couldn't open file.");
$msg = "<p>File has added data...</p>";
fclose($myfile);
?>

<?
$filename = "list.txt";
$whattoread = @fopen($filename, "r") or die("Couldn't open file");
$file_contents = fread($whattoread,
filesize($filename));
$msg = "Songs to Download:<br>$file_contents";
fclose($whattoread);
?>

<head>
<title>Songs to Download</title>
</head>
<body>
<? echo "$msg"; ?>
</body>

Anon

well, um, it doesn't look like you are PRINTing out $newstring anywhere, just assigning to it.

jburfield

I believe you need to add an fputs() line to your script...

After opening the file, and before closing it, add this:

fputs($file, $newstring);

That should write the contents of $newstring to the file $file.

I'm not sure if this makes a difference of not, but in the line that reads:

$newstring = "$artist - $title\n";

You may want to change it to:

$newstring = "$artist" . " - " . "$title";

Not sure on that last part though...just off the top of my head.

-- Jason

Anon

hmm, i put that "fputs($file, $newstring); " right before the close, and it just produced an error "Warning: Supplied argument is not a valid File-Handle resource"

Anon

That should be:

fputs($myfile,$newstring);

Since you stored the file pointer from fopen() in $myfile NOT $file.

Anon

thanks man, the only problem is, that it wont add to the file, it just creates it, and replaces what's existing there, I want it to just add onto it.. that's why I put \n after it "$artist - $title\n"

Anon

Then you need to use:

$myfile = @fopen($filename, "a") or die("couldn't open file.");

Notice the "a" and NOT "w+"

From the PHP manual:

'w+' - Open for reading and writing; place the file pointer at the beginning of the file and truncate the file to zero length. If the file does not exist, attempt to create it.

'a' - Open for writing only; place the file pointer at the end of the file. If the file does not exist, attempt to create it.