Nested while loops - 2nd loop doesnt exe

dewcansam

/ BACKGROUND /
I have a function that is desigend to create dynamic html checkboxes. I want some checkboxes to be checked by default when page loads. Currently it works with a small annoyance. One function writes a javascript function and a user must mouseover a html link to select the default checkboxes. I want to do away with the javascript.
Query 1: select n_id from tbl where id = $id :: retrives a string of note id's where product id = id
Query 2: select id, name from n_tbl :: retrives id, name from the notes table

/ CODE /
function qry_checkbox($query, $default="", $check_name="", $prefix="", $attrib="", $suffix="", $vl="n")
{
/ $query (str) /
/ $default (ary) /
$output = "";
$selected = "";
$result = mysql_query($query);
$checkbox_link = ereg("href", $prefix);/ find out if user is adding a html hyperlink to $prefix and set $checkbox_link to 1/
$suffix = $suffix . "\r\n"; / allow user to add html after the text string label /
$user_prefix = $prefix;

while (list($key, $val) = mysql_fetch_array($result))
{
  while (list($key2, $val2) = each($default))
  {
    $selected = $val2[0] == $key ? "checked" : "";
  }
  if ($checkbox_link == 1) 
  {        
    /* set $prefix to include $check_name with $key */
    /* this allows for creation of html hyperlinks */
    $prefix = $user_prefix . $key . "\">" . "<input type=\"checkbox\" name=\"".$check_name."__".$key."\""; /* allow user to add html before the input tag */
  } 
  else 
  {
    /* set $prefix to include $val with $check_name */
    $prefix = $user_prefix . "<input type=\"checkbox\" name=\"".$check_name."__".$key."\""; /* allow user to add html before the input tag */
  }
  $output .= "$prefix value=\"$val\" $selected $attrib >$val$suffix";
}

return $output;
}

/ OUTPUT /
<tr><td><a href="notes.php?action=edit&id=1"><input type="checkbox" name="note1" value="Free Tech" >Free Tech </a></td></tr>
<tr><td><a href="notes.php?action=edit&id=6"><input type="checkbox" name="note6" value="Low cost" >Low cost</a></td></tr>

/ PREFERRED OUTPUT /
<tr><td><a href="notes.php?action=edit&id=1"><input type="checkbox" name="note1" value="Free Tech" CHECKED >Free Tech</a></td></tr>
<tr><td><a href="notes.php?action=edit&id=6"><input type="checkbox" name="note6" value="Low cost" CHECKED >Low cost</a></td></tr>

/ PROBLEM /
The first while loop exes correctly drawing the html. The second while loop only loops through once never anding the 'CHECKED' attribute.

amcgrath

Shouldn't this : $selected = $val2[0] == $key ? "checked" : "";

really be: selected = ($val2 == $key ? "checked" : "");

(I added the parens myself, but check $val2 instead....)

amcgrath

I assume $default is an array being passed...

dewcansam

Correct.
However $default is an array in itself. That is why I need to run through it (the 2nd while loop) for all notes.

Summed up. I need to run through loop_1 for checkboxes then for each checkbox I need to run through another array (loo_2) to find out if the checkbox should be selected or not.

amcgrath

Ok, then how about this:

$tick = 0; // this is new
while (list($key, $val) = mysql_fetch_array($result))
{
while (list($key2, $val2) = each($default))
{
$selected = $val2[$tick] == $key ? "checked" : "";
$tick++;

dewcansam

Got back a Undefined offset error.

dewcansam

I noticed something intresting about the nested while loop that if I replaced it with a function call to function that I had designed to loop through an array then the function would be called for all the notes. Going on that I wrote another function called chk_default_checkbox($ary, $default). And that did it. So if anybody has a clue as to why the nested loop didn't work but the function call does I would like to hear the explanation. Also I needed to break out of loop_2 when ever $selected == "checked" and because I wasn't doing that $selected would revert back to "" unless the last value was true.

while (list($key, $val) = mysql_fetch_array($result))
{
$selected = "";
$selected = chk_default_checkbox($default, $key);
if ($checkbox_link == 1)
{
/ set $prefix to include $check_name with $key /
/ this allows for creation of html hyperlinks /
$prefix = $user_prefix . $key . "\">" . "<input type=\"checkbox\" name=\"".$check_name."".$key."\""; / allow user to add html before the input tag /
}
else
{
/ set $prefix to include $val with $check_name /
$prefix = $user_prefix . "<input type=\"checkbox\" name=\"".$check_name."".$key."\""; / allow user to add html before the input tag /
}
$output .= "$prefix value=\"$val\" $selected $attrib >$val$suffix";
}
return $output;
}

dewcansam

Better yet add a return statement if $ary is not an array. In other words if no checkboxes are selected by default then just go back to what you were doing.