Why doesn't this work (Redirect)

polarbear66

Take a look at this code. $Customer is a session variable I created on the page before. If it has a value and I echo it, it will display. If I check to see if it doesn't have a value and echo, say, "Not Registered", it works fine. I have deleted everything from my page except for this little snippet and it still won't work. All I want to do is check to see if $Customer has a value, if not, redirect to the login page. There is no spaces above or below the <?...?>. I get "Cannot add header information - headers already sent". This is all I have on the page. I know a refresh through meta would work but this is not practical for me.

<?php
session_start();
if (!$Customer) {
header("Location:http://localhost/login.html");
}
?>

Anon

Do you have any automatically included scripts?

techek

What a chunk of explanation! Thank God you've also included some code ...

I'm almost certain that this line of code would work :

<?php
header("Location: http://localhost/login.html");
?>

Note that space between the "Location:" and the URL! Actually you could leave out that "http://localhost/"-part and just redirect to "login.html".

The way I normally debug a script would be to either echo variables, force a control-structure to a TRUE expression and the watch the result. If you're "new" to PHP, you have at least two (2!) possible points of failure in your script above. So : echo, echo and echo ... (or use the debugger-feature in PHP - see www.php.net!)

[deleted]

Are you sure that that is ALL there is on the page? It is not allowed to print ANYTHING at all before running the session_start and header().

This includes any HTML or spaces/newlines that may appear outside the <? ?> tags

Anon

I just want to say that Vincent is an annoying, useless cunt that actually helps NO ONE!!!! So, i know i am not alone when i say Vincent, FUCKOFF!!!!

emcb_php

Hi,

yes i have had this problem from time to time and it normally works when i build the url in a variable and then try the redirect.

$redir = "http://".$SERVER_NAME."/login.html";
header("Location: $redir");
exit;

Always remember to use the exit; at the end of the redirect header.

Hope this helps,

Elfyn

emcb_php

I must also say that i am very new to php and realise that im NOT the best programmer on the world but someone should have spotted the non-existant exit; by the haeader.

And to Me, why dont you @!#$ off, because vincent has been very helpful to a lot of newbiez, and i certainly havent seen you helping anyone here!

lucianoes

I've never been able to use that 'debugger-feature' you mention...

:-(

    Luciano ES
    Santos - SP - Brasil

polarbear66

Using the code you listed works. Infact I used the following code and it worked.

<?php
session_start();
$redir = "Location: login.html";
header($redir);
exit;
?>

But once I use the IF statement, it dies on me.

<?php
sesstion_start()
$redir = "Location: login.php";
if (!$sesCustomerID) {
header($redir);
exit;
}
?>

I am positive that there is nothing else running, I am just trying to call the session variable I created on the page before and check to see if it has a value. If it doesn't, redirect.

polarbear66

Nothing, If I use the redirect without the IF statement then it works. But once I check to see if the variable contains a value, the it doesn't work.

polarbear66

I echoed my variables to see if it was working and it appears to be working just fine. Using the code you listed works. Infact I used the following code and it worked.

<?php
session_start();
$redir = "Location: login.html";
header($redir);
exit;
?>

But once I use the IF statement, it dies on me.

<?php
sesstion_start()
$redir = "Location: login.php";
if (!$sesCustomerID) {
header($redir);
exit;
}
?>

I am positive that there is nothing else running, I am just trying to call the session variable I created on the page before and check to see if it has a value. If it doesn't, redirect.

polarbear66

I am positive. I could send you the page and it would have a total of 6 lines in it. I am not printing or echoing and there is no HTML in this page. In fact, I can redirect at will as long as the IF statement isn't in there. I tested it. Once I check to see if the variable contains a value, the the script breaks.

junebug

there is a very simple solution to this problem. change your script to look like this:

<?
session_start()
if(!isset($customer)){
header("Location: http://some/where.html");
}
?>

if the variable $Customer is not set, and you try to check if it is false, you get an error because there is no variable $Customer. since the error sends out info to the browser, you cannot send out a header. so use the isset() function and all your troubles will be solved.

junebug

um, damn. anger managment. anyway, if you had any brains, you would see that he help everybody here. and before you can help someone you have to ask questions. and sometimes they are dumb questions but lots of people make dumb mistakes. so really, unless you have something useful to say, don't say anything at all because all you have done is just made an ass of yourself.

polarbear66

Thanks for your help. That works perfectly. I though I was going insane.

polarbear66

Thanks for everyones help. Here is the code that finally worked.

Thanks for your help. This is the code that finally worked.

<?php
session_start();
$redir = "Location: http://localhost/login.html";
if (!isset($Customer)) {
header($redir);
exit;
}
?>

I know I don't exactly need the $redir but it was in there when I got it to work. If it ain't broke....

Again, Thanks Everyone

[deleted]

lol

techek

Good to hear! And I think we all got something sorted out along the way. HI5's to everyone making the PHP-community to what it is - damn I'm proud!

PS : Good idea to include the final result SoH ...