Pass Error but me can't find it

[Anon]

here is the code

=============================================
<?php
include ("config.php");
if($your_password=="$password" && $your_name=="$username")
{
$your_date = date("M j, Y h:i:s");
$fp=fopen("./comments.dat", "a");
fputs($fp, "<tr><td>Posted by <a href=mailto:$your_email>$your_name</a> at $your_date</td></tr><tr><td>$your_comments</td></tr>");
fclose($fp);

$new = "<tr><td>Posted by <a href=mailto:$your_email>$your_name</a> at $your_date</td></tr><tr><td>$your_comments</td></tr>";

$f = fopen("comments.dat", "r");
$old = fread($f, filesize("comments.dat"));
fclose($f);

$new .= $old;

$f = fopen("comments.dat", "w");
fwrite($f, $new);
fclose($f);
";

}
else{
echo"Incorrect password.";
}

?>

the pass error is on line 26

test it out here
http://216.118.121.28/snewzdemo/newz1.php
post ther news here
http://216.118.121.28/snewzdemo/postsnewz1.php

asny help would be appreciated
thanks
cya
Sam Colebatch
[e-mail]
http://www.samcolebatch.com

[Anon]

sorry bout the typos

[emcb_php]

Hi,

I have had that problem but worked around it using:

<?
$comments = "./comments.dat";
if ($fp = fopen($comments, "a") {
while(feof($fp)) {
puts($fp, $your_comments);
fclose($fp);
}
}
?>

Dont know why its not workinf for you though,

Elfyn

[Anon]

so your saying I should use that code you gave me instead of mine??
yeh I know this pass error is starting to bug me.
Does the rest of my code seem alright
thanks

[Anon]

that code you gave me still doesn't work
this pass error is starting to bug me

[emcb_php]

Hi,

Yes to me it looks fine but try using the workaraound if fopen fails to work. Im also wuite new to php and have had this problem so im now expert, but your code looks fine to me.

Elfyn

[mithril]

If a variable currently contains a string (as $password and $username will), it's already a string. Thus, you don't need to enclose the variable in quotes. Try changing

&nbsp;&nbsp;if($your_password=="$password" && $your_name=="$username")

to

&nbsp;&nbsp;if($your_password==$password && $your_name==$username)

-geoff

[[deleted]]

is that quote at line 22 a typo too?

[Anon]

I will attempt that.
But here is something new,
I have now attempte to have all the scripts in one file eg news.php and viewnews.php

But there is a pass error on line 43.
Do you think you could help me.
The script is bellow in the attachment

Post news here -
http://216.118.121.28/snewz1/postsnewz1.php
View news here -
http://216.118.121.28/snewz1/snewztest.php?viewsnewz
See the script here -
http://216.118.121.28/snewz1/snewz.txt

Once again I appreciate it if you where to also have a look at the
rest of the script if you like to see if there are anyother errors in it
thanks
cya

[Anon]

you mean this??
fwrite($f, $new);

[[deleted]]

no, I mean this line

<snip snip>
fwrite($f, $new);
fclose($f);
"; <<<-- this bit here

}
<snip snip>

[Anon]

thanks for all your help with this.
I appreciate it
cya