If function works, re-direct page

[bjblackmore]

Hi,
I'm trying to execute a function, and it it works it will open another page, and if not it will return an error message.
So I have: -

include($DOCUMENT_ROOT.'/include/book.php');

(Document where the function is).

if ($submit) {
$worked=book($day,$month,$year,$total,$title,$forename,$surname,$address,$town,$county);
if ($worked){
Header("Location: http://www.domain.co.uk/confirmation.php");
}
}

This is so when you press submit, the function 'book' is run, this emails the details to me, and enters info into a database. If it works I want it to forward to confirmation.php which gives a confirmation screen. However if it doesn't work, I want it to show error feedback. In the book code, i have
if (!$day || !$month || !$year || !$total || !$title || !$forename || !$surname || !$address || !$town || !$county) {
$feedback .= ' ERROR - Please Fill In All Fields ';
return false;
}
However even if these fields are left blank, the form still forwards onto confirmation.php, but surely $worked would return false and not work?
Any help greatly appreciated
Cheers
Ben

[soulreaver]

Personally I'd use javascript for this, something along the lines of

<script language="Javascript">
<!--

function Validate()
{

var problem;
problem="";

if (document.form1.link_name.value=="")
{
problem+="Enter a Vacancy name please.\n";
}
if (document.form1.summary.value=="")
{
problem+="Enter a Summary please.\n";
}
if (document.form1.expire.value=="")
{
problem+="Enter a Date please.\n";
}
if (problem=="")
{
form1.submit();
}
else
{
alert (problem);

} 	

}

//-->
</script>

Then your form would have something along the lines of

<input type="button" value="Update Vacancies" OnClick="Validate();">

for the submit button.

Here is the form for clarity

<form enctype="multipart/form-data" name="form1" action="update.php" method="post">
<b>Vacancy Name</b><br><br><input type="text" name="link_name"><br><br>(Assign The Vacancy Name Here)</td>

		  <td><b>Summary</b><br><textarea rows="5" cols="30" name="summary"></textarea><br>
      Click <a href="hr_preview.php">here</a> to preview the page</td>
		</tr>

		<tr>
		  <td><b>Browse for the file you want to upload</b><br><input type="hidden" name="MAX_FILE_SIZE" value="2048000"> <input type="file" name="fupload"></td>
			<td><b>Enter Closing Date</b><br><input type="text" name="expire"></td>
		</tr>


		<tr>
		  <td><input type="button" value="Update Vacancies" OnClick="Validate();"></td>
    <td colspan="2"><input type="reset" name="Clear" value="Clear Form"> </form>

Hope this helps

Neil

[cordex]

Try something like

if ($day == '' || $month == '' || $year != '' || $total == '' || $title == '' || $forename == '' || $surname == '' || $address == '' || $town == '' || $county == '')
{
$feedback .= ' ERROR - Please Fill In All Fields ';
return false;
}

Also, try var_dump()ing the variables to see what values they have.

-Ben