Array in Function

Anon

i am building a function that takes an array as an argument, then loops thru the array and 'cleans' the data stored in each value....

typical user input kinda cleaning.....

this is what I have so far:

function clean_userinput($array){
global $cleanarray;
while (list($key, $value) = each($array)){
$value = trim($value);
$value = escapeshellcmd($value);
$cleanarray[$key] = $value;
}
return $cleanarray;
}

this is returning a completely new array - what I would like to do is return the same array that was passed in to the function - for example, if i were to pass $HTTP_GET_VARS into the function, I would like to use the same $HTTP_GET_VARS array name once the functon has done its thing, rather than $cleanarray....

can this be done???

thanks

hometoast

Yes. Use Pass by Reference.
http://www.php.net/manual/en/language.references.php
should explain it way better than I could in a post.

Anon

tahnks

Anon

OK, I dont quite get the manual....

This is what I am doing, just to test, but it deoesn't seem to work....can anyone spot anything wrong????:

<?php

function clean(&$array){
while (list($key, $value)=each($array))
{
$value = trim($value);
$value = escapeshellcmd($value);
$cleanarray[$key] = $value;
}
}

$newarr = array(
"?><''()_-[{}|@$##",
"Missu's",
"/etc/passwd"
);

// loop through dirty array

while(list($k,$v) = each($newarr)){
echo $k . ": " . $v . "<br>";
}

echo "<br><br>";

// clean array

cleanup($newarr);

// loop through clean array

while(list($k1,$v1) = each($newarr)){
echo $k1 . ": " . $v1 . "<br>";
}

can anyone see wht I am doing wrong???

rrijnders

Your function name is "clean" but you are calling "cleanup" in the program.

-- Rich

hometoast

I actually see a couple of things.. in addition to you using cleanup() and defined only clean().

Also in your clean function .. you set an array.. $cleanarray.. which goes nowhere.. you need to either return it or copy it to the array you passed in to the funcion... you clean function results in NOTHING being done. $cleanarray is a local variable.