[PHP] userlist will not work

Anon

please will somebody with more experience with php-scripting look at this script and tell me what's wrong. Because he won't show mij userlist.

if (file_exists("vars.php")):
include("vars.php");
endif;

</HEAD>

<?
echo "<body bgcolor=\"$bgcolor\" text=\"$text\" link=\"$link\" vlink=\"$vlink\" alink=\"$alink\">";
echo "<font face=\"$font\" size=\"$size\">

<table bgcolor=\"$bgcolor\" border=\"1\" cellspacing=\"0\" cellpadding=\"2\" bordercolor=\"$bordercolor\" bordercolorlight=\"$bordercolor\" bordercolordark=\"$bordercolor\">
<tr>
<td>
<font face=\"$font\" size=\"$size\" color=\"$color\"><b>Online zijn:</b>
</td>
</tr>";

exec("find userlist/ -amin 1 -o -amin 0",$retAr);
$numusers = sizeof($retAr);
for ($i=0;$i<$numusers;$i++)

if ($retAr[$i] != ""): echo "<tr><td><font face=\"$font\" size=\"$size\">".ereg_replace("userlist/","",$retAr[$i])."</td></tr>"; endif;

</table>
</BODY>

thanx for helping me out!

Anon

two problems here
1. This is not wrong, however, sizeof shouldn't be used to determine the number of elements.
yes, I know sizeof will return the number of elements in php but
it is historically used to return the number of bytes reserved for a variable or data type. Use count() instead.

Your example has a space immediately after the for loop (you are shooting blanks). Enclosing your statement in brackets will prevent these types of errors from reoccuring in the future.

try this

for($i = 0; $i < count($retAr); $i++) {
//dostuff
}

bloan wrote:

$numusers = sizeof($retAr); <--- UUUuuGGGggg!!!!
for ($i=0;$i<$numusers;$i++)

if ($retAr[$i] != ""): echo "<tr><td>".ereg_replace("userlist/","",$retAr[$i])."</td></tr>"; endif;

?>

Anon

thanx man, it helpt me al lot!