Undefined Variable Error

Anon

Hi, I'm new to PHP and am developing a personal contact manager. I'm having trouble with the following code giving me this errors. Any help is appreciated.

Undefined variable: <b>valid</b> in c:\inetpub\wwwroot\intranet\contacts\contact_menu.php on line 14.
Undefined variable: <b>show_form</b> in c:\inetpub\wwwroot\intranet\contacts\contact_menu.php on line 43

<?
session_start();
$op = "op";
if ($op == "ds") {
if (($username != "admin") || ($password !="abc123")) {
$msg = "<P><font color=\"#FF0000\"><strong>Bad Login - Try Again</strong></font></P>";
$show_form = "yes";
} else {
<b>LINE 14</b>session_register('valid');
$valid = "yes";
$show_menu = "yes";
}
} else {
If ($valid == "yes") {
$show_menu = "yes";
} else {
$show_form = "yes";
}
}
$form_block = "
<h1>Login</h1>
<FORM method=post action=\"$PHP_SELF\">
<P><strong>username:</strong><br>
<input type=\"text\" name=\"username\" size=15 maxlength=25></P>
<P><strong>Password:</strong><br>
<input type=\"password\" name=\"password\" size=15 maxlength=25></P>
<input type=\"hidden\" name=\"$op\" value=\"ds\">
<br>
<P><input type=\"submit\"name=\"submit\"value=\"login\"></P>
</FORM>";
$menu_block = "
<h1>Contact Administration System</h1>
<P><strong>Administration</strong>
<ul>
<li><a href=\"show_addcontact.php\">Add a Contact</a>
<li><a href=\"pick_modcontact.php\">Modify a Contact</a>
<li><a href=\"pick_delcontact.php\">Delete a Contact</a>
</ul>
<P><strong>View Records</strong>
<ul>
<li><a href=\"show_contactsbyname.php\">Show Contacts, Ordered by Name</a>
</ul>";
<b>LINE 43</b> If ($show_form == "yes") {
$display_block = $form_block;
} else if ($show_menu == "yes") {
$display_block = $menu_block;
}
?>

<HEAD>
<TITLE>Contact Management System</TITLE>
</HEAD>
<BODY>
<? echo "$display_block"; ?>
</BODY>

fitzbean

You have alot of confusing code that is not needed. Try the following:

<?
session_start();
session_register('valid');

$display_block = $form_block;

$menu_block = "
<h1>Contact Administration System</h1>
<P><strong>Administration</strong>
<a href='show_addcontact.php'>Add a Contact</a>
<a href='pick_modcontact.php'>Modify a Contact</a>
<a href='pick_delcontact.php'>Delete a Contact</a>
<P><strong>View Records</strong>
<a href='show_contactsbyname.php'>Show Contacts, Ordered by Name</a>";

$form_block = "
<h1>Login</h1>
<FORM method=post action='$PHP_SELF'>
<P><strong>username:</strong><br>
<input type='text' name='username' size=15 maxlength=25></P>
<P><strong>Password:</strong><br>
<input type='password' name='password' size=15 maxlength=25></P>
<input type='hidden' name='op' value='ds'>
<br>
<P><input type='submit'name='submit'value='login'></P>
</FORM>";

if ($op == "ds")
{
if (($username == "admin") && ($password == "abc123")) {
$display_block = $menu_block;
$valid = 'yes';
} else { $msg = "<P><strong>Bad Login - Try Again</strong></P>"; $display_block = $form_block; }
}

<HEAD>
<TITLE>Contact Management System</TITLE>
</HEAD>
<BODY>
<? echo "$display_block";
echo "<P>$msg</P>";
?>
</BODY>

Anon

Thanks for the suggestion. I tried this and got three new errors:

Warning: Undefined variable: form_block in c:\inetpub\wwwroot\intranet\contacts\contact_menu1.php on line 5

Warning: Undefined variable: op in c:\inetpub\wwwroot\intranet\contacts\contact_menu1.php on line 28

Warning: Undefined variable: msg in c:\inetpub\wwwroot\intranet\contacts\contact_menu1.php on line 43

Could this be a PHP error? Perhaps it would help to clarify that I'm using PHP for windows, running IIS 4.0 on Windows XP.

Anon

There not set, just as you said. You need to set them before requesting a variable that hasn't been used before...

try....

if( !isset($form_block) ) { $form_block = ""; }
if( !isset($op) ) { $op = ""; }
if( !isset($msg) ) { $msg = ""; }

put that at the top before $display_block = $form_block;

fitzbean

Hmm that must be a version related or something error, because that code works fine on my server. PHP is a loosely typed language and you don't have to delcare variables before using them.