simple log-in, but big problem

[witold]

hi, i got stuck at this piece of code for a while now. the proble is that it doesn't redirect to desired pages, but rather hangs up.

if ($user == 'journalist') {
$sql = "SELECT pass, login FROM members WHERE pass='$pass' and login='$login'";
$result = mysql_query($sql,$connection) or die ("no connection with the DB");
$num = mysql_numrows($result);
if ($num == 1) {
header('Location: journalists.php');
}
else {
header('Location: register_journalist.php');
}
}
else {
$sql = "SELECT pass, login FROM members WHERE pass='$pass' and login='$login'";
$result = mysql_query($sql,$connection) or die ("no connection with the DB");
$num = mysql_numrows($result);
if ($num == 1) {
header('Location: customers.php');
}
else {
header('Location: register_customer.php');
}
}
mysql_close($connection);

Any tips what may be wrong with it?

witold

[Anon]

Your problem may be a simple timeout from the database. Related to this is the fact that you do not free the result set.
However, exactly why your code hangs is a mystery to me. Perhaps if you published the whole page?

--- clarified code ---

$query = "SELECT pass, login FROM members WHERE pass='%s' and login='%s'";
$sql = sprintf($query, $pass, $login); 
$result = mysql_query($sql, $connection) or die ("no connection with the DB"); 
$num = mysql_numrows($result); 
mysql_free_result($result);
mysql_close($connection); 

$legit_user = array(
	'journalist',
	'customer'
);

$link = "";

if(in_array($user, $legit_users))
{
	if($num >= 1)
	{
		$link = $user."s";
	}
	else
	{
		$link = "register_".$user;
	}
	header('Location: '.$link.'.php');
}
else
{
	// user is not correct - deal with it
}