silly if statements

[Anon]

I expect this to go only through one of the if statements but its goign through them all and printing 1234.
why? anyone knows??

$formatis = $HTTP_GET_VARS['formatis'];
if($formatis='newvhs'){
echo "1";
$query_price = tep_db_query("select products_id, price_new_vhs as price, price_new_dvd, price_used_vhs, price_used_dvd, products_price from products where products_id = '" . $HTTP_GET_VARS['products_id'] . "'");
}
if($formatis='newdvd'){
echo "2";
$query_price = tep_db_query("select products_id, price_new_dvd as price, price_new_vhs, price_used_vhs, price_used_dvd, products_price from products where products_id = '" . $HTTP_GET_VARS['products_id'] . "'");
}
if($formatis='useddvd'){
echo "3";
$query_price = tep_db_query("select products_id, price_used_dvd as price, price_new_dvd, price_new_vhs, price_used_vhs, products_price from products where products_id = '" . $HTTP_GET_VARS['products_id'] . "'");
}
if($formatis='usedvhs'){
echo "4";
$query_price = tep_db_query("select products_id, price_used_vhs as price, price_new_vhs, price_new_dvd, price_used_dvd, products_price from products where products_id = '" . $HTTP_GET_VARS['products_id'] . "'");
}

[marcel]

try with
if($formatis=='foo')
instead of
if($formatis='foo')

PM

[cordex]

for each if statement, you are saying:
$formatis='value'
or assigning 'value' to $formatis.

Try changing the $formatis= to $formatis== on each of them.

[amcgrath]

In addition to the above, why not use if.. elseif or, switch? You're evaluating the same value, it's the scenario if...elseif and switch were meant for....

[Anon]

thanx guys, you guys are great!

R.

[Anon]

I would also recommend for easier reading and understanding:

$query_price = tep_db_query("select products_id, price_new_vhs as price, price_new_dvd, price_used_vhs, price_used_dvd, products_price from products where products_id = '" . $HTTP_GET_VARS['products_id'] . "'");

Is by the looks a very commons piece of code in this script. Wouldn't it be easier to:

if ($formatis='newvhs') { echo '1'; }
elseif ($formatis='oldvhs') { echo '2'; }
elseif ($formatis='badvhs') { echo '3'; }
elseif ($formatis='foovhs') { echo '4'; }
if (isset($formatis)) {
$query_price = tep_db_query("select products_id, price_new_vhs as price, price_new_dvd, price_used_vhs, price_used_dvd, products_price from products where products_id = '" . $HTTP_GET_VARS['products_id'] . "'");
}

...or something similiar. Just ideas to keep things abit easier on the eye... There are other ways to do the above too.

// Thomasson

[cordex]

er ... Thomasson ... you made the same mistake Rooin did ...

You still need to use == rather than = for comparison.

Still, if I were doing this, I'd make a switch like Allen suggested.

[cordex]

Here you go, Ronin:

http://www.hvt-automation.nl/yapf/faq.php?cmd=viewitem&itemid=95