a few php questions

Anon

say if I had this to log in
<? if ($action == "login") {
if ($username == "admin" || $password == "admin") {
setcookie("admin", "loggedin", "+3600");
header('Location: admin.php');
} else { echo "wrong password";
}
} elseif ($action == "logout") {
setcookie("admin", "", "-3600");
header('Location: admin.php'); }?>

then I had this

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HEAD><TITLE>Snewz WMS</TITLE><META content="MSHTML 5.00.2614.3500" name=GENERATOR></HEAD>
<BODY aLink=#000000 bgColor=#ffffff link=#000000 text=#000000 vLink=#000000>

<?
if($admin == "loggedin") { ?>
etc etc

how would I get the username from the person loging in.

Say would I go <?
if($admin == "loggedin") {
echo "welcome $username";?>

would that then diplay the username of that person on the page where ever I put welcome username.

Also how would I make my login script more secure?

thanks

Anon

anyone there

amcgrath

Well, when you initially log them in, why not set the username to a cookie and reference that?

Anon

do you mean something like this

if ($action == "login") {
setcookie("admin", "loggedin", "+3600");
} else { echo "Welcome $username";}

amcgrath

Yes, exactly (well I normally set a variable then set the cookie, that way since code doesnt have access to cookies until the next request, you'll have it.

Anon

swoit that means I got one code right for once!!