is there anything wrong with this query?

[lentildal]

hi all

is there anything wrong with this query?

it doesnt seem to be working...

$query = "UPDATE table_name SET commentid = 'NULL', commentname = '$comm_name[$id]', commentmail = '$comm_mail[$id]', commentsite = '$comm_site[$id]', commentcomment = '$comm_comm[$id]' commentdte = 'NULL' WHERE commentid = '$id'";
$res = mysql_query($query);

[Anon]

$query = "UPDATE table_name SET commentid = 'NULL', commentname = '$comm_name[$id]', commentmail = '$comm_mail[$id]', commentsite = '$comm_site[$id]', commentcomment = '$comm_comm[$id]' commentdte = 'NULL' WHERE commentid = '$id'";
$res = mysql_query($query);

Is the table_name really table_name, or did you probably mean $table_name?

Check all the field names, that is a common problem. If that doesn't work add:

echo mysql_error();

after calling mysql_query() and see what it tells you.

[lentildal]

hi bit, thanks for your reply

that missing $ was just a typo, i also added a missing comma between the last two entries.

i added mysql_error but got nothing back :-/

[Anon]

Did you add

echo mysql_error();

or

mysql_error

?

'jobee

[alfbennett]

Try Echoing out your query after it is built to make sure that the value for commentid is actualy there. If it is not you probably will not get an error because the sql executed properly, but there were no rows to update. At least you will be able to see what you are sending to the database, and see if it is OK