Loop problem

[Anon]

Hi,
I wrote this script in order to check for users that have their birthdate today and send them a Happy Birthday e-mail.

The problem is that it does check the users but is sending only to one, assuming that there are for example 5.

I think that the script is not checking for every user but only for one, or is checking every user but there need to be a loop for sending the e-mail to all that satisfy the criteria.

Any help would be great on debugging this.
Thanks

Here's the script:

<?
// Include configuration file
require ("config.inc.php");
require ("$lib/lib.php");
// Print top navigation
$page_code = "user";
$page_name = LANG_HEADERCONFIRM;
{

 //Get today date
 $tod = date("Y-m-d");

 // Connect database
 dbconnect();

 // If confirmation completed, select user info
 $sql = "SELECT email, name, surname, username, password, birthdate FROM $t_users

WHERE birthdate = '$tod'";
$result = @($sql)
or die ("Can not find user info.");
while ($row = mysql_fetch_array($result))
{
$co_email = $row['email'];
$c_name = $row['name'];
$c_surname = $row['surname'];
$c_username = $row['username'];
$c_password = $row['password'];
$c_birthdate = $row['birthdate'];
}
@mail($co_email, LANG_HAPBTHD,
"$tod,\n
".LANG_DEAR." $c_name $c_surname\n\n".LANG_MENSPARAB."

---

\n".LANG_MELCPTOS."
".LANG_EQUIP." $site_name", "From: $admin_mail");

}
?>

[Anon]

The mail() function call should be inside the while() loop.

Diego

[Anon]

Thanks for your reply.

That's what I thought, but I'm not an expert in coding and the problems goes there - what should be changed to make that happen?

[Anon]

Ok, discard my last comment. 😉

It was just a matter of changing the "}" a steps down. I was blind on this or the so called sympathy error.

Thanks a lot for the tip!

Diego Huang wrote:

The mail() function call should be inside the while() loop.

Diego

[Anon]

Diego Huang wrote:

The mail() function call should be inside the while() loop.

Diego

Well, now the problem seems to be that we would like to keep the format Y-m-d on the db table but we would like to check only the month and day to the condition returns TRUE.

Any thoughts?

[Anon]

You can probably do something like this in your SQL query:

WHERE MONTH(birthdate) = MONTH('$tod') AND DAYOFMONTH(birthdate) = DAYOFMONTH('$tod')

Diego

[marioproenca]

Hi

Thanks for the excellent help! It worked allright.

Mario Pro