Login Script

Anon

Could someone look this over and tell me what in the hell is wrong with it? I had it working perfectly and then I added sessions and now its gone caput.
I getting this error:
Warning: Supplied argument is not a valid MySQL result resource in /host/d/a/r/p/o/r/dark-storm14.port5.com/login.php on line 18
Plus I'm not sure that my Header() works.

Here it is:

<?php
session_start();

print ("");
print ("<head></head>");
print ("<body bgcolor=\"#000000\" text=\"#ffffff\">");

require ("univvars.php");

if (mysql_connect($Host, $User, $Pass))
{
if (mysql_select_db($DBName, $Link))
{
$Query = "SELECT Username, Rank, Money, Country from users WHERE Username='$Array[Username]' AND Password='$Array[Password]'";

	$Result = mysql_query($Query, $Link);

	$num = mysql_num_rows($Result);

	if ($Submitted)
	{
		if ($num == 1)
		{
				$Rank = $Array[Rank];
				$Money = $Array[Money];
				$Country = $Array[Country];

				session_register('Username');
				session_register('Rank');
				session_register('Money');
				session_register('Country');

	        		header("Location: index.php");
		}

	}
	else
	{
		print ("<td><center><b>Login:</b><br>");
		print ("<tabe border=1 width=\"25%\"><form action=\"login.php\" method=POST>");
		print ("Username:<br>");
		print ("<input type=text name=\"Array[Username]\">");
		print ("<p>Password:<br>");
		print ("<input type=password name=\"Array[Password]\"><br>");
		print ("<input type=hidden name=\"Submitted\" value=\"TRUE\">");
		print ("<br><input type=Submit name=\"Submit\" value=\"Submit\"></td>");
	}
}

}
else
{
print ("Could not open page. Please try back later. If problem persists, contact webmaster at soldier_of_rome@hotmail.com.");
}
?>

robro

I think you should assign $Link to the connection on Line 10.

If you put in a few indents your code might be a bit more readable.

In order to help track down where your failures are it helps to put in an 'or die' part into your mysql statments. That will tell you where your code actually fails.

mysql_query AFAIK does't require the $Link variable. I believe that if you want to include the Link variable(If you have more than one DB open) you should use mysql_db_query. Regarding "or die"'s I would suggest changing line 14(I think it was line 14) to:

$Result = mysql_query($Query) or die("Query Failed on Line 14<br><br>Query was:<br>$Query");

Using this aproach will help debugging your code.

Showing us the included files(univvars.php) could also be a help, as would the structure of the Database.