Loop Construct

Anon

i have a form where the user sets the number of rows, but the first 3 elements are always what I need to insert into DB. I can't seem to get a loop that will insert the proper data into the proper fields:

i've been working with this:


$arr = array_values((${"HTTP_".$REQUEST_METHOD."_VARS"}));
$row = array( $arr[0], $arr[1], $arr[2]);
foreach($row as $key => $value )
{
	$sql = "INSERT INTO recipe( ingredient, portion_type, portion_amt ) VALUES ( '$row[0]', '$row[1]', $row[2] )";
	$result = mysql_query( $sql ) or die ( mysql_error() );

}

Any help is always appreciated,

Pete

Anon

I'm just wondering what you mean by this:

$row = array( $arr[0], $arr[1], $arr[2]);
foreach($row as $key => $value )
{
$sql = "INSERT INTO recipe( ingredient, portion_type, portion_amt ) VALUES ( '$row[0]', '$row[1]', $row[2] )";
$result = mysql_query( $sql ) or die ( mysql_error() );

}

Why are you doing a foreach loop, and then using $row[0], $row[1], and $row[2]? The point of having a foreach loop is so that you can use $key and $value.

Diego

tomhath

Not sure what you mean by "proper data into the proper fields", but you are assuming array_values will put your form variables into $arr in a certain order. I don't think that's a safe assumption.

Try indexing it as an associative array instead of by array position. For example:

$arr['ingredient'] instead of $arr[0]

pas07920

Solution:

for( $i = 0; $i < floor( sizeof( ${"HTTP" . $REQUEST_METHOD . "VARS"} ) / 3 ); $i++ )
$rows[ $i ] = Array( ${"HTTP" . $REQUEST_METHOD . "VARS"}[ "ingredient" . $i ],
${"HTTP" . $REQUEST_METHOD . "VARS"}[ "tfPortionAs" . $i ],
${"HTTP" . $REQUEST_METHOD . "VARS"}[ "tfPortionSize" . $i ] );

foreach( $rows as $row )
{
$sql = "INSERT INTO recipe( ingredient, portion_type, portion_amt ) VALUES ( '" .
$row[ 0 ] . "', '" . $row[ 1 ] . "', " . $row[ 2 ] . " )";
mysql_query( $sql ) or die ( mysql_error() );
}