ereg_replace problems

boldingl

I'm using php4.1.1 on Linux...

I have the following string...

$sql = "select table.id, table.user, table.pass, FROM table, WHERE table.id='1234' AND table.user='lee' AND ORDER BY table.id DESC";

This is being automatically generated based on the amount of arguments passed to the script (which explains the superflous ,'s and ANDs). So, I'm using ereg_replace to remove them like so:

$sql = ereg_replace(', FROM', ' FROM', $sql);
$sql = ereg_replace(', WHERE', ' WHERE', $sql);
$sql = ereg_replace('AND ORDER', 'ORDER', $sql);

However, this doesn't actually DO anything to $sql - is this function simply not working? or do I have the syntax wrong? (is it something to do with the comma in the pattern?)

Thanks...

Anon

Could it be so that you wrote this inside a function and forgot to add:
return $sql ; ?

Alternative that you do
not send $sql into the function and have not
made $sql global ?

function killpath($str)
{
$str = ereg_replace("..","",$str);
return $str;
}

Regards Jonas

boldingl

Yes, its inside a class and I'm declaring $this->sql = $sql after the ereg functions.

There also seems to be a problem with the third replace - this doesn't contain any special characters except a space.

I've tested it with a pattern that contains no spaces or special characters and it works fine... is there an escape character I need to use? (I've tried \ and \)

Anon

Your script works fine. This is what I used:

<?
$sql = "select table.id, table.user, table.pass, FROM table, WHERE table.id='1234' AND table.user='lee' AND ORDER BY table.id DESC";
$sql = ereg_replace(', FROM', ' FROM', $sql);
$sql = ereg_replace(', WHERE', ' WHERE', $sql);
$sql = ereg_replace('AND ORDER', 'ORDER', $sql);
print $sql;
?>

and it does replace it...The output was:

select table.id, table.user, table.pass FROM table WHERE table.id='1234' AND tab
le.user='lee' ORDER BY table.id DESC

So the error is in some other part of your code.

Diego

boldingl

there must be bug in 4.1.1 then, or maybe because I have PCRE compiled in... because I'm not even executing the sql - just echoing it back.

Nice to know that there is nothing wrong with the code, though.

I'll report it as a problem to php.net

Anon

Well, I'm using PHP 4.1.0, but I doubt it's a bug in PHP 4.1.1...

Try running my script and see what you get. If you get the right output, then it's something with your code...

Diego