No output from function. SOS!!!

Anon

Let me tell what I am doing.

I am trying to find objects and their sizes in a web page.
Then display
- each object location
- each object size
- total object size.
Here's my code:
<?
$basedir = "/home/www/html";
$wdir = "/nikar/";
$srcpat = "([sS][rR][cC]=\"([^\"]+)\")";
$hrefpat = "([hH][rR][eE][fF]=\"([^\"]+)\")";
$bkgpat = "([bB][aA][cC][kK][gG][rR][oO][uU][nN][dD]=\"([^\"]+)\")";

function find_obj($pattern, $string)
{
global $ObjStr;
global $srcpat;
global $hrefpat;
global $bkgpat;
global $basedir;
global $wdir;
static $sum = 0;
if (preg_match_all($pattern, $string, $Matches))
{
array_shift($Matches);
foreach($Matches as $match)
{ $src_list[] = $match;}

while (list($key, $var) = each($match))
{
$objsize = filesize($basedir."/".$var);
$sum = $sum + $objsize;
echo"$key => ".$var."size = ".$objsize." bytes<br>";
}
}
return $sum;
}

find_obj($srcpat, $ObjStr);
find_obj($hrefpat, $ObjStr);
find_obj($bkgpat, $ObjStr);

echo "total object size = ".$sum;
?>

I get the following result :
0 => graphics/logo4.gif size = 16433 bytes
1 => graphics/logo3.gif size = 4705 bytes
2 => graphics/logo2.gif size = 9302 bytes
3 => nikar/sql_mysql.txt size = 15570 bytes
4 => menu.html size = 1966 bytes
0 => menu.html size = 1966 bytes
1 => index.html size = 564 bytes
0 => graphics/logo1.gif size = 9461 bytes
total object size =
My question is, why don't I get the value of $sum at the end of the display? Please advise.

Anon

<?php

$basedir = $GLOBALS[DOCUMENT_ROOT];
$wdir = "/nikar/";
$srcpat = "([sS][rR][cC]=\"([^\"]+)\")";
$hrefpat = "([hH][rR][eE][fF]=\"([^\"]+)\")";
$bkgpat = "([bB][aA][cC][kK][gG][rR][oO][uU][nN][dD]=\"([^\"]+)\")";
$sum = 0;

function find_obj($pattern, $string)
{
global $basedir;

if (preg_match_all($pattern, $string, $Matches)) 
{ 
	array_shift($Matches); 
	foreach($Matches as $match) 
	{
		$src_list[] = $match;
	} 

	while (list($key, $var) = each($match)) 
	{ 
		$objsize = filesize($basedir."/".$var); 
		$sum+=$objsize; 
		echo "$key => $var size = $objsize bytes<br>"; 
	} 
}
return $sum;

}

$sum+=find_obj($srcpat, $ObjStr);
$sum+=find_obj($hrefpat, $ObjStr);
$sum+=find_obj($bkgpat, $ObjStr);

echo "total object size = ".$sum;
?>

that should work, I haven't tested it though.

Really all you need to do is get rid of the static var line and add $sum+= to your find_obj calls.

You also had a few global vars in there which didn't seem to need to be there, so I took them out.

HTH

tomhath

The function returns the value of $sum, but you never did anything with the returned value. Try storing it someplace:

var $totalsize = 0;

$totalsize += find_obj($srcpat, $ObjStr);
$totalsize += find_obj($hrefpat, $ObjStr);
$totalsize += find_obj($bkgpat, $ObjStr);

echo "total object size = ".$totalsize;

tomhath

Better answer than I gave. I didn't pay any attention to all the global and static declarations inside the function. You might need to initialize $sum to zero at the top of the function, but as kyboshed mentioned, don't make it static or global.

By the way, the regexes would be simpler if you used "case insensitive" matching instead of typing in both upper and lower case letters.

If you ever think you really need to use static variables in a function, you probably would be much better off defining a class (read up on Objects). That's what they're for.