MySQL not valid Resource?!?

[Anon]

Hi guys,

I got this page here...

http://www.protahertz.net/ta/ladder/players.php as you can see it says

Warning: Supplied argument is not a valid MySQL result resource in /usr/local/plesk/apache/vhosts/protahertz.net/httpdocs/ta/ladder/inc_players.php on line 50

well here is inc_players.php

<?php
require('variables.php');
require('variablesdb.php');
?>
<p align="right" class="text"><font size="3">Players</font></p>
<div align="center">
<center>
<?php
$db = mysql_connect("$datbaseserver", "$databaseuser", "$databasepass");
mysql_select_db("$databasename",$db);
$sortby = "name ASC";
$sql="SELECT FROM $playerstable ORDER BY $sortby";
$result=mysql_query($sql,$db);
$yo = mysql_num_rows($result);
$number = 0;
$link = 1;
$finishnumber = $numplayerspage;
$startnext = $start + $numplayerspage;
$startprevious = $start - $numplayerspage;
echo "<p class='text'>Go to page:";
if ($startprevious >= 0) {
echo "&nbsp;|&nbsp;<a href='$directory/players.php?start=$startprevious&finish=$finishnumber'><</a>&nbsp;|";
}
while ($number < $yo) {
echo "&nbsp;<a href='$directory/players.php?start=$number&finish=$finishnumber'>$link</a>&nbsp;|&nbsp;";
$number = $number + $numplayerspage;
$link = $link + 1;
}
if ($start < $yo - $numplayerspage) {
echo "<a href='$directory/players.php?start=$startnext&finish=$finishnumber'>></a>&nbsp;|";
}
?>
<br>
<br>
<table border="0" cellpadding="1" width="90%">
<tr>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class="text">Name</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class="text">Mail</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class="text">ICQ</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class="text">Aim</td>
</tr>
<tr>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
</tr>
<?php
$db = mysql_connect("$databaseserver", "$databaseuser", "$databasepass");
mysql_select_db("$databasename",$db);
$sortby = "name ASC";
$sql="SELECT FROM $playerstable ORDER BY $sortby LIMIT $start, $finish";
$result=mysql_query($sql,$db);

$num = mysql_num_rows($result);
$cur = 1;

echo "<ol>";

while ($num >= $cur) {

$row = mysql_fetch_array($result);

$name = $row["name"];
$mail = $row["mail"];
if ($mail == "n/a") {
$maillink = "n/a";
}
else {
$maillink = "<a href='mailto:$mail'>mail</a>";
}
$icq = $row["icq"];
if ($icq == "n/a") {
$icqlink = "n/a";
}
else {
$icqlink = "<a href='http://wwp.icq.com/scripts/Search.dll?to=$icq'>$icq</a>";
}
$aim = $row["aim"];
if ($aim == "n/a") {
$aimlink = "n/a";
}
else {
$aimlink = "<a href='aim:addbuddy?screenname=$aim'>$aim</a>";
}
$country = $row["country"];

?>
<tr>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class='text'>&nbsp;<?php echo "<img src='$directory/flags/$country.bmp' align='absmiddle'>&nbsp;<a href='$directory/profile.php?name=$name'>$name</a>"?>&nbsp;<?php echo "$penplayer" ?>&nbsp;<font color="<?php echo "$color" ?>"><?php echo"$text" ?></font>&nbsp;</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class="text"><?php echo "$maillink" ?></td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class="text"><?php echo "$icqlink" ?></td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="left" nowrap><p class="text"><?php echo "$aimlink" ?></td>
</tr>
<?php

$cur++;
}

echo "</ol>";

?>
<tr>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
<td width="20%" bgcolor="<?php echo"$color4" ?>" align="center" nowrap><p class="text">&nbsp;</td>
</tr>
</table>
</center>
</div>
<center>
<?php
$db = mysql_connect("$databaseserver", "$databaseuser", "$databasepass");
mysql_select_db("$databasename",$db);
$sortby = "name ASC";
$sql="SELECT * FROM $playerstable ORDER BY $sortby";
$result=mysql_query($sql,$db);
$yo = mysql_num_rows($result);
$number = 0;
$link = 1;
$finishnumber = $numplayerspage;
$startnext = $start + $numplayerspage;
$startprevious = $start - $numplayerspage;
echo "<p class='text'>Go to page:";
if ($startprevious >= 0) {
echo "&nbsp;|&nbsp;<a href='$directory/players.php?start=$startprevious&finish=$finishnumber'><</a>&nbsp;|";
}
while ($number < $yo) {
echo "&nbsp;<a href='$directory/players.php?start=$number&finish=$finishnumber'>$link</a>&nbsp;|&nbsp;";
$number = $number + $numplayerspage;
$link = $link + 1;
}
if ($start < $yo - $numplayerspage) {
echo "<a href='$directory/players.php?start=$startnext&finish=$finishnumber'>></a>&nbsp;|";
}
?>

i don't understand what is wrong with my code, to produce a the error message.

Maybe any pro's out there can pick up code errors?

That would be most greatful thanks 😃 😃

Elmer

[Anon]

I've lost count too many times which line is line 50, so to help debugging your code, when using mysql, use "or die('informative error message')"

change for example
mysql_connect($host,$user,$pass);
to
mysql_connect($host,$user,$pass) or die("Connection to Database Failed");

or mysql_query($sql)
to
mysql_query($sql) or die("Query Failed");

I'm on a shite computer at the minute, but I'll take a closer look at your code when I get a better computer with a decent text editor.

[Anon]

On the line immediately after mysql_query() you might wanna put "echo mysql_error()"

It will give you an error message telling you what part of your query is causing the problem.