unable to insert data into mysql

[Anon]

Hey guys I am new to mysql but things are coming along pretty good. I have my database created and now I want to be able to add information to it with an html form. So far I have the script below but it is not working, it just gives me the die() message after the query. Does any one see where I went wrong here?

print("<form method='post' action=$PHP_SELF>
<br>
Username: <input type='text' name='username' size='25'>
<br>
First Name: <input type='text' name='fname' size='25'>
<br>
Last Name: <input type='text' name='lname' size='25'>
<br>
Street Address: <input type='text' name='street_address' size='25'>
<br>
State: <input type='text' name='state' size='2'>
<br>
Zip: <input type='text' name='zip' size='5'>
<br>
Phone: <input type='text' name='phone' size='12' value='xxx-xxx-xxxx'>
<br>
Domain: <input type='text' name='domain' size='25'>
<br>
Account TYpe: <input type='text' name='account_type' size='25'>
<br>
<input type='submit' name='submit' value='press once to add'>&nbsp;&nbsp&nbsp;<input type='reset' value='cancel'>
<br>
</form></body>");

if(isset($submit)) {
if(empty($username) || empty($fname) || empty($lname) || empty($street_address) || empty($zip) || empty($phone) || empty($domain) || empty($account_type)) {
die("you did not enter all of the requried information");
} else {
$query = "INSERT INTO users VALUES( , '$username', '$fname', '$lname', '$street_address', '$state', '$zip', '$phone', '$domain', '$account_type'";
$insert = mysql_query($query) or die("you messed up");
print(mysql_errno()." ".mysql_error());
}
}

mysql_close($link);
?>

[bryanzera]

Try removing the comma before $username in the VALUES of the query string. SQL is picky about things like that.

[[deleted]]

Not much point in printing the errors after the 'or die' killed your script is there? :-)

change this

$insert = mysql_query($query) or die("you messed up");
print(mysql_errno()." ".mysql_error());

to this:

if (!mysql_query($query))
{
&nbsp;&nbsp;echo $query.'<BR>'.mysql_errno().' '.mysql_error());
};

[Anon]

Is there any of these characters going into the database ' " / because if there is then you must use the addslashes(); function.
Hope this helps