mysql_fetch_array + while loops

[ellisgl]

Ok, I've been working on a project and I have the hard part almost done (everything else is easy). And I have made a function and tested it out, but it will cut off the first and last DB entries. So here's the code:
<pre>
<?php
$dbhost = "localhost";
$dbuser = "admin";
$dbpass = "";

mysql_connect($dbhost,$dbuser,$dbpass);

function floor_table($floor)
{
mysql_select_db("einet");
$result=mysql_query("SELECT * FROM einet WHERE floor=$floor");?>
<table width="100%" border="0" cellspacing="0" cellpadding="1">
<tr>
<td bgcolor="#000000">
<table width="100%" border="0" cellspacing="0" cellpadding="1">
<tr bgcolor="#0099CC">
<td colspan="4"><font size="5">Floor <?php echo $floor;?></font></td>
</tr>
<?php
while ($row = mysql_fetch_array($result))
{
echo "<tr bgcolor=\"#FFFFFF\">\n";
for($cnt=0;$cnt<=3;$cnt++)
{
while ($row = mysql_fetch_array($result))
{
echo "<td>".$row["room"]." (<a href=\"blah\">off</a>)</td>\n";
break;
}
}
echo "</tr>\n";
}
echo "</table>\n";
}
floor_table(1);
?>
</pre>

[balsdorf]

I can see why you are losing the first entry but not the last. The problem is you call mysql_fetch_array() twice. Whenever you call mysql_fetch_array() it returns the result set and advances it to the next row. So you call the row in your first loop without displaying the results and then pull the next row in your 2nd loop. I assume you have the first loop to make sure there are records returned. I would change the code to be like this:

if (mysql_num_rows() > 0)
{
echo "<tr bgcolor=\"#FFFFFF\">\n";
for($cnt=0;$cnt<=3;$cnt++)
{ while ($row = mysql_fetch_array($result))
{
echo "<td>".$row["room"]." (<a href=\"blah\">off</a>)</td>\n";
break;
}
}
echo "</tr>\n";
}
echo "</table>\n";

This should show you the first row. I am not sure about why the last row isn't showing but let me know how this works for you and I will see what I can do.

[ellisgl]

Ok.. That's a bit better.. So my code is now:
<code>
<pre>
<?php
$dbhost = "localhost";
$dbuser = "admin";
$dbpass = "";

mysql_connect($dbhost,$dbuser,$dbpass);

function floor_table($floor)
{
mysql_select_db("einet");
$result=mysql_query("SELECT * FROM einet WHERE floor=$floor");?>
<table width="100%" border="0" cellspacing="0" cellpadding="1">
<tr>
<td bgcolor="#000000">
<table width="100%" border="0" cellspacing="0" cellpadding="1">
<tr bgcolor="#0099CC">
<td colspan="4"><font size="5">Floor <?php echo $floor;?></font></td>
</tr>
<?php
if (mysql_num_rows($result)>0)
{
echo "<tr bgcolor=\"#FFFFFF\">\n";
for($cnt=0;$cnt<=3;$cnt++)
{
while ($row = mysql_fetch_array($result))
{
echo "<td>".$row["room"]." (<a href=\"blah\">off</a>)</td>\n";
break;
}
}
echo "</tr>\n";
}
echo "</table>\n";
echo "</tr>\n";
echo "</table>\n";
}
floor_table(1);
?>
</pre>
</code>
But it only makes one row.
I would have thought it would have continued to loop.. =\

[ellisgl]

Hmmm.. I've tried different loops and I took out the breaks.. And end up with endless loops or all the entries on the same row, instead of a new one.

[ellisgl]

Figured it out..
for ($i = 0; $i < ceil(mysql_num_rows($result)/4); $i++)
{
echo "<tr bgcolor=\"#FFFFFF\">\n";
for $cnt=0;$cnt<=3;$cnt++)
{
while ($row = mysql_fetch_array($result))
{
echo "<td>".$row["room"];
echo " (<a href=\"?op=editroom&room=".$row["room"]."\">off</a>)</td>\n";
break;
}
}
echo "</tr>\n";
}