error handling my functions

[m31uw]

I need to test ftp_login for errors, the function I have connects fine but if the username, passwd, or servername is incorrect, ftp_login fails and spills errors all over my page. This is what it looks like:

function connect()
{
global $server, $username, $password;
$conn = ftp_connect($server);
ftp_login($conn, $username, $password);
return $conn;
}

$conn is returned so it wiil always be true so I can't test if that's true or false. I checked the manual and I'm still not sure what to test for.

Can anyone help me out?

[Anon]

You should check $conn before logging in, because what if $conn is false? ftp_login will give you an error also. So maybe something like this:

function connect()
{
global $server, $username, $password;
$conn = ftp_connect($server);
if ($conn) {
$login = ftp_login($conn, $username, $password);
if (!$login) {
ftp_close($conn);
return false;
}
}
return $conn;
}

Diego

[m31uw]

Thanks, the modification you gave me gives me a true/false condition to work with but still spills warnings on my screen, but this time not in the html (which is a little better).

I tested it a couple of ways and still can't get rid of the warnings (from bogus login). Forgive me if my php skills aren't up to par, I'm still getting used to it.

Can I use error_reporting()? or just conditional test true or false to bring user back to login page.

-thankx