What's wrong with this?

Anon

From the script below, I get the following error:
Warning: Supplied argument is not a valid MySQL result resource in /home/floorgaz/public_html/links/reID.php on line 14

now, it DOES change the id number like it is supposed to do in the script but it always ends up with that error. And when I hit refresh as many times as how many rows there is in that table, that table will disappear and when i look, all the IDs are all in order from 1 to whatever number. What's up with this?!

Here's the script below:

<?php
print "\n<head>";

// Whatever heading
print "</head>\n\n<body>\n\n\n\n";

require ("includes.php");

// SET VARIABLES
$count = 0;

$result = mysql_query("SELECT * FROM crewInfo");
while ($row = mysql_fetch_array($result))
{
$count++;
$newId = $row['id'];

//IF THE CURRENT $count NUMBER IS NOT EQUAL TO THE CURRENT ROW ID: $newId
if ($count != $newId)
{
//THEN IT WILL CHANGE IT TO $count
$result = mysql_query("UPDATE crewInfo SET id='$count' WHERE id='$newId'");
}

}

print "\n</body>\n\n\n";

proproject

Change the second "$result =" to "$result2 = " and I bet it will work.

You are overwriting the first query result with the result of the update query inside the loop, before you are done using the first query result.

Roger

tomhath

The first time through the loop it will work. You do a "select" and put the resulting resource into $result. The "while" fetches the first row. The "update" updates a row and clobbers the $result resource. The next iteration of the "while" fails because you stepped on the resource with the "update"...

Anon

OMG. I've thought of that but I couldn't figure out a way to do that..But I went around it and did something that works too...in a way. Here it is:

function change($oldID, $newID) {
if ($newID != $oldID)
{
//THEN IT WILL CHANGE IT TO $count
$result = mysql_query("UPDATE users SET id='$newID' WHERE id='$oldID'");
} else {
print "There was an error.";
}
}

// SET VARIABLES
$count = 0;

$result = mysql_query("SELECT id FROM users");
while ($row = mysql_fetch_array($result))
{
$count++;
$oldID = $row[id];
$newID = $count;
change($oldID, $newID);

}

I figured that out after about a couple of hours of looking through php.net and it took that long for this response to come in. HAH. What luck of mines. Thanks for the help though. Thanks again.