exec() copy and spaces ?

Anon

Hi there gang,

hopefully this will be a pretty easy one for someone out there, but i cant seem to figure it out.

I have an upload section on my website where people can go and upload a photot to a database. All in all it works pretty well, but i discovered a problem the other day in that, if someone uploads a file (.jpg) with a space in the name my script doesnt work.

The following is what i am trying to do.

if ($image_name != "") {

copy("$image", "temp/original/$image_name") or die ("Couldn't copy the file.");
exec(/usr/bin/convert -geometry 200 temp/original/"$image_name" temp/thumbs/"$image_name", $error);
exec(/usr/bin/convert -quality 80 temp/original/"$image_name" temp/big/"$image_name", $error);

} else {

die("You forgot to add a filename. Please click the back button and try again.");

It will put the file in the "original" directory, but it wont do the other two parts (converting). If there are no spaces in the filename it works fine.

Also, can someone point me in the right direction or supply some sample code to let me know how i can put a condition in here that says the must MUST be jpg pr jpeg format?

Thanks in advancefor any help

Regards

Dave

Anon

Okay, first of all, I'd go with using exec as follows;

exec("/usr/bin/convert -geometry 200 \"temp/original/$image_name\" \"temp/thumbs/$image_name\"", $error);

(i.e. get the filepath + filename enclosed in ". That ought to help you.

One side comment though, it's generally a very bad idea to use filenames coming from the user. They can be used to trick your scripts into doing something they're not supposed to. Have a look at escapeshellcmd() and escapeshellarg()!

Checking if a file is of type jpeg can be done in several ways. If you have GD with JPEG-support, you can easily do this;

$imageattr = GetImageSize("filename.jpg");
if ($imageattr[2] != 'image/jpeg') {
print 'Not a valid JPEG image';
} else {
print 'Valid JPEG image';
}

Alternatly, you can try the file(1) command (in linux shell).

--
[terje@www images]$ file pc.jpg

pc.jpg: image/jpeg

Wich, as you can see, is very elegant way of determining file-types. If you don't have JPEG magic numbers in your magic file ('man file' for more info), use the following lines;

Regular JPEG

0 beshort 0xffd8 image/jpeg

HSI is Handmade Software's proprietary JPEG encoding scheme

0 string hsi1 image/jpeg

Hope that helped 🙂

Anon

Tnanks for that Terje,

The first bit worked perfectly, now no problems with spaces.

But the second bit throws me somewhat. Please excuse my ignorrance but im still quite new to this.

My original code was:

if ($image_name != "") {

copy("$image", "temp/original/$image_name") or die ("Couldn't copy the file.");
exec("/usr/bin/convert -geometry 200 \"temp/original/$image_name\" \"temp/thumbs/$image_name\"", $error);
exec("/usr/bin/convert -quality 80 \"temp/original/$image_name\" \"temp/big/$image_name\"", $error);

And the code you gave me an example of for checking filetypes was:

$imageattr = GetImageSize("filename.jpg");
if ($imageattr[2] != 'image/jpeg') {
print 'Not a valid JPEG image';
} else {
print 'Valid JPEG image'; <- I assume this is where i put my own code????
}

My question is, im not sure how to get these two working together.

Which one should be getting checked first?

Some sample code of the two put together would be much appreciated.

Regards

Dave

Anon

Well, as far as I can see, the "flow" in this system has to be;

1) Copy the file to its new location
2) Check if it's a valid image (although you might want to accept gif and png as well as JPEG?)
3) If allowed type, continue, else erase image and exit
4) Resize the images and put into the respective directories

And from that, I slap together some code;

// Copy the image, step 1
copy("$image", "temp/original/$image_name") or die ("Couldn't copy the file.");

// Get the image properties, much useful information can be gained from the GetImageSize() function.
// http://www.php.net/manual/en/function.getimagesize.php

$imageattr = GetImageSize("temp/originame/$image_name");

// $imageattr[2] is a flag indicating the type of the image. 1 = GIF, 2 = JPG, 3 = PNG, 4 = SWF, 5 = PSD, 6 = BMP

// If type is between 1 and 3 (gif, jpg and png), set $validImage to 1, else set it to 0.
// If you want it strictly JPG, use;
// if ($imageattr[2] == 2) $validImage = 1; else $validImage = 0;

if (($imageattr[2] > 0) && ($imageattr[2] < 4)) $validImage = 1; else $validImage = 0;

// If it's not a valid image, issue an error message and delete the uploaded file.
if (!$validImage) {
print 'This image is not a valid JPG, PNG or GIF image.<br>';
unlink("temp/original/$image_name");
} else {
// And if it is a valid image, perform the imagemagick stuff.
exec("/usr/bin/convert -geometry 200 \"temp/original/$image_name\" \"temp/thumbs/$image_name\"", $error);
exec("/usr/bin/convert -quality 80 \"temp/original/$image_name\" \"temp/big/$image_name\"", $error);

// And report OK..
print 'OK.<br>';
}

Didn't try it, but it's supposed to work. Hope it helped :-)

Anon

Thanks Terje!

Once again your suggestions have worked nicely!.

The only thing left to do is, id like to be able to know how to stop the script from going any further at the point that it discovers it is not a JPG.

<head>
<STYLE>UNKNOWN {
TEXT-DECORATION: none
}
A:hover {
CURSOR: crosshair; COLOR: white; TEXT-DECORATION: none; COLOR: white; BACKGROUND-COLOR: #0080FF;}

</STYLE>

<title>Thankyou!</title>
</head>
<body bgcolor="#00003E" link="#FFFFFF" vlink="#FFFFFF" leftmargin="0">
<?
include "../inc/top.php";
?>

<?
include "../inc/left.php";
?>

</td>
<td width="60%" align="center" valign="top">

include "../inc/header.inc";
include "../inc/settings.inc";

// $imageattr = GetImageSize("filename.jpg");
// if ($imageattr[2] != 'image/jpeg') {
// print 'Not a valid JPEG image';
// } else {
// print 'Valid JPEG image';
// }

if ($image_name != "") {

copy("$image", "temp/original/$image_name") or die ("Couldn't copy the file.");

$imageattr = GetImageSize("temp/original/$image_name");

if ($imageattr[2] == 2) $validImage = 1; else $validImage = 0;

if (!$validImage) {
print 'This image is not a valid JPG image.<br>';
unlink("temp/original/$image_name");
} else {

exec("/usr/bin/convert -geometry 200 \"temp/original/$image_name\" \"temp/thumbs/$image_name\"", $error);
exec("/usr/bin/convert -quality 80 \"temp/original/$image_name\" \"temp/big/$image_name\"", $error);

}

} else {

die("You forgot to add a filename. Please click the back button and try again.");

}

$insert_data = "INSERT INTO temp (image_name, image, name, email, country, airfield, rego, remarks, airline, date, month, year) VALUES ('$image_name', 'processed/big/$image_name', '$name', '$email', '$country', '$airfield', '$rego', '$remarks', '$airline', '$date', '$month', '$year')";

mysql_query($insert_data) or die("Couldn't insert data.");

$msg = "Another Pic has been uploaded!!\n\n";
$msg .= "Photographer:\t$name\n";
$msg .= "Sender E-Mail:\t$email\n";
$msg .= "Airline:\t$airline\n";
$msg .="Country:\t$country\n";
$msg .= "Registration:\t$rego\n";
$msg .= "Remarks:\t$remarks\n";
$msg .= "Image is located at:\t$website/$img_location\n";
$msg .= "After processing it will be at:\t$website/$img_processed";

$recipient = "me@host.com";
$subject = "File $image_name Uploaded!!";
$mailheaders = "From:uploads<> \n";
$mailheaders .= "Reply-To: $email\n\n";

mail($recipient, $subject, $msg, $mailheaders);

print "<font face=\"Arial\" size=\"2\" color=\"white\">Thank you for uploading your photo to us. As soon as we have time we will get round to processing it for you<br><br>Click <a href=\"\">HERE</a>to add another photo</font>\n";

</td>
<td width=20%>
</td>
</tr>
</table>

</div>

<?
include "../inc/footer.inc";
?>

</body>

I have some other stuff down in the script - for example an email gets sent to me with every upload, and also a thankyou message. I dont obviously wan tthem to print out if it is not a JPG - but at present it is completing the rest of the script even if it not a JPG (except for the imagemagik stuff.). THe sql info is all still being entered.

How do i get it to die at the:
print 'This image is not a valid JPG image.<br>';

Many thanks once again. !

Dave

Anon

Sorry about the font color.....didnt realise it would do that.

<head>
<STYLE>UNKNOWN {
TEXT-DECORATION: none
}
A:hover {
CURSOR: crosshair; COLOR: white; TEXT-DECORATION: none; COLOR: white; BACKGROUND-COLOR: #0080FF;}

</STYLE>

<title>Thankyou!</title>
</head>
<body bgcolor="#00003E" link="#FFFFFF" vlink="#FFFFFF" leftmargin="0">
<?
include "../inc/top.php";
?>

<?
include "../inc/left.php";
?>

</td>
<td width="60%" align="center" valign="top">

include "../inc/header.inc";
include "../inc/settings.inc";

// $imageattr = GetImageSize("filename.jpg");
// if ($imageattr[2] != 'image/jpeg') {
// print 'Not a valid JPEG image';
// } else {
// print 'Valid JPEG image';
// }

if ($image_name != "") {

copy("$image", "temp/original/$image_name") or die ("Couldn't copy the file.");

$imageattr = GetImageSize("temp/original/$image_name");

if ($imageattr[2] == 2) $validImage = 1; else $validImage = 0;

if (!$validImage) {
print 'This image is not a valid JPG image.<br>';
unlink("temp/original/$image_name");
} else {

}

} else {

die("You forgot to add a filename. Please click the back button and try again.");

}

mysql_query($insert_data) or die("Couldn't insert data.");

$recipient = "dave@comlink.net.au";
$subject = "File $image_name Uploaded!!";
$mailheaders = "From: rwy34.com uploads<> \n";
$mailheaders .= "Reply-To: $email\n\n";

mail($recipient, $subject, $msg, $mailheaders);

</td>
<td width=20%>
</td>
</tr>
</table>

</div>

<?
include "../inc/footer.inc";
?>

</body>

Dave