Memory limit reached with 17K

Anon

Hi.

I'm trying to get the following function to work, but keep getting an out of memory error. But I don't understand why. The text-file passed is only 17K big, and in the loop I use I only read one time (about 40 characters) at a time. PLEASE HELP. Here's the function. You can also see it as a txt file at http://home.hetnet.nl/~babipanghang/makequeries.php .

<?php
function MakeQueries ($InputFile, $InsertTable){
$file = fopen($InputFile, "r"); // Open the input text-file.

if ($file <> false){                             // check if the text-file was opened correct.
	while (!feof ($file)){                       // While we are not at the end of the file
		$TextFile = fgets($file, 100000);        // Read a line from the text file. 
										         // fgets should stop at 100000 bytes , eof, or a line-end.
		$ThisRow = explode("|", $TextFile);      // Get all text in the file between | in elements in an array.
		for ($B = 0;$B <= count($ThisRow);$B++){ // for every element in ThisRow do
			$ThisRow[$B] = trim($ThisRow[$B]);   // remove whitespaces at the beginning and end of the string.
		}

		// Now print the query that we want.
		printf("INSERT INTO $InsertTable VALUES(NULL, '$ThisRow[0]', '$ThisRow[1]', '$ThisRow[2]');<BR>");

		$ThisRow = NULL;                         // Clear any memory ThisRow was using.
		$TextFile = NULL;                        // Clear any memory TextFile was using.
	}
} else {
	printf("File openen mislukt.");              // Tell us if the script can't open the file.
}

}

MakeQueries("input.txt", "domeinverkoop"); // Carry out the MakeQueries function.
?>

rrijnders

Let's parse this loop:

for ($B = 0;$B <= count($ThisRow);$B++){
  $ThisRow[$B] = trim($ThisRow[$B]);
}

Just for fun, let's assume that $ThisRow starts with one element in it. At the start of your loop:

$B is set to 0
$count($ThisRow) evaluates to 1

zero IS less than or eqaul to 1 so your loop goes ahead and trims $ThisRow[0]. So far, so good.

But the structure of the for loop dictates that $B gets incremented ($B++) so now:

$B is set to 1
$count($ThisRow) evaluates to 1

1 IS STILL less than OR EQAUL TO 1 so your loop goes ahead and trims $ThisRow[1].

"BUT WAIT! I DON'T HAVE A $ThisRow[1]!" you say. Well, you DO NOW! So:

$B gets incremented to 2
$count($ThisRow) evaluates to... 2!

2 IS STILL less than OR EQAUL TO 2 so your loop goes ahead and trims $ThisRow[2].

"BUT WAIT! I DON'T HAVE A $ThisRow[2]!" you say. Well, you DO NOW! So:

$B gets incremented to 3
$count($ThisRow) evaluates to... 3!

3 IS STILL less than OR EQAUL TO 3 so your loop goes ahead and trims $ThisRow[3].

"BUT WAIT! I DON'T HAVE A $ThisRow[2]!" you say. Well, you DO NOW! So...

...Are you getting the picture?

Generally, it is never a good idea to use an evaluation in a loop control; especially an evaluation of a variable that gets modified inside the loop.

Instead, use:

$numElements = count($ThisRow);
for ($B = 0; $B<$numElements; $B++){
  $ThisRow[$B] = trim($ThisRow[$B]);

HTH
--Rich

Anon

Thanks a lot! Haven't tried it yet, but that must be it...