HELP...confused

Anon

Thanks for any help in advance , i am new to this stuff. All i am trying to do is upload an image (stored in folder) ,image_name name ,description ,price to the database. As i say i am new, i was wondering if anyone can tell me whether this code should be working. Ths images get to the folder fine as far as uploading those goes, but nothing seems to be getting to my db...is this because i have an <form action="up_go.php"> as well as a if(isset($submit)) at the bottom of the page?....

<td><b>Image upload</b><br></td>
<td></td>
</tr>
<tr>

<td><input type="File" name="userfile" size="30" maxlength="255"><br>
</td>
</tr>
<tr>
<td><b>target filename: </b><br></td>
<td><input type="Text" name="image_name" size="30" maxlength="^255"><br>
</td>
</tr>
<tr>
<tr>
<td><b>upload diretory: </b><br></td>
<td>c:\program files\apache group\realdocs\files\antiquesbasic\images</td>
</tr>
<td colspan="2" align="CENTER">
<INPUT TYPE="submit" VALUE="upload">
</td>
</tr>
</FORM>
<?php
if (isset($submit)) {
$db = mysql_connect("localhost","root");
mysql_select_db("antiques",$db);

$sql = "INSERT INTO general (name,description,price,image_name) ".

"VALUES ('$name,$description,$price,$image_name')";
 }
 ?>

</body>

conical

$sql = "INSERT INTO general (name,description,price,image_name) ".

"VALUES ('$name,$description,$price,$image_name')";

That should be

INSERT INTO general (name, description, price, image_name) VALUES ('$name','$description','$price','$image_name')

Of course, to put it in, you'll need to do

mysql_query($sql) or die(mysql_error())

the dir(mysql_error()) part means that the script will stop execting tehre and it'll tell you the problem with your SQL query.

-adun

Anon

So if i have changed that code and added the mysql_query but when i run this script....

<body>

<?php

$db = mysql_connect("localhost", "root");

mysql_select_db("antiques",$db);

$result = mysql_query("SELECT * FROM general",$db);

if ($myrow = mysql_fetch_array($result)) {

echo "<table border=1>\n";

echo "<tr><td>Name</td><td>Description</td><td>Price</td></tr>\n";

do {

printf("<tr><td>%s %s</td><td>%s</tr>\n", $myrow["name"], $myrow["description"], $myrow["price"]);

} while ($myrow = mysql_fetch_array($result));

echo "</table>\n";

} else {

echo "Sorry, no records were found!";

}

?>
</body>

Which should i'm guessing, give me the data thats in the db or at least the name, description, price but all i get is "sorry, no records were found", so i guess that the info is till not getting there. ????

van__

What's with the die() usage?
I never could figure that out.
Just because we generated a bad query doesn't mean that we should be showing a blank or partial page and expose our guts to the world by divulging our database query info.

Not bashing on you, just that I see that all the time:
die("some error message that a surfer doesn't need and could help a hacker exploit your service");

And I just consider it bad form for a website. I mean, die is great for shell scripting, but a webpage?

Dunno, I use custom error handling so the page draws something pretty as a place holder and sends me email.

Just wondering.

conical

hmm, I mainly only use die() when im deveoping my pages... I remove it after I find out the query works. after that i'll just put some indescreet message like die("cannot connect"); or something like that

-adun

conical

Did you use phpmyadmin or soemthing of the sort to make sure the data from the form made it into the db?

(assuming the query didnt give back an error)

-adun

van__

Ya I hear that, it's nice to force it to caugh up debug tips for you, but even then, I just use echo to show the query for the block I'm working on.

And like I said, I wasn't bashing you, I've seriously seen that in so many scripts, even on live sites and never could quite understand what the hell people saw in that.

Anon

So nice discussion there about die(mysql_error()). Ummm phpmyadmin ? no i guess, a am just puttering along trying to learnthis stuff in a aweful hurry, i would have thought it would have made it into the database if that code was right. Is there a chance that my form action="up_go.php" could be conflicting witht the upload of that text data? the up_go.php sends the image to the image folder, and displays all the information that the user entered into the form, so i suppose at least its going somewhere, but not everywhere i want....????

van__

<?php

$db = mysql_connect("localhost", "root");

mysql_select_db("antiques",$db);

$result = mysql_query("SELECT * FROM general",$db);

if (mysql_num_rows($result)) {
echo "<table border=1>\n";
echo "<tr><td>Name</td><td>Description</td><td>Price</td></tr>\n";

while ($myrow[] = mysql_fetch_array($result)) {
printf("<tr><td>%s %s</td><td>%s</tr>\n", $myrow["name"], $myrow["description"], $myrow["price"]);
}

echo "</table>\n";

} else {
echo "Sorry, no records were found!";
}
?>

Anon

Thanks van, i ran that script, which was very similiar to what i was using to query my db to see if anything was in it, but again all i got was "sorry no ...." so their must be something very wrong somewhere along the line. I dont know enough about this stuff to weed it out, the script i am using to upload info......

<b>Name</b><br>
<input type="Text" name="name" size="25">
<br>
<b>Description</b><br>
<input type="Text" name="description" size="25">
<br>
<b>Price</b><br>
<input type="Text" name="price" size="25">
<br>
<td><b>Image upload</b><br></td>
</tr>
<tr>
<td><input type="File" name="userfile" size="30" maxlength="255"><br></td>
</tr>
<tr>
<td><b>target filename: </b><br></td>
<td><input type="Text" name="image_name" size="30" maxlength="^{255"><br></td>}
</tr>
<tr>
<tr>
<td><b>upload diretory: </b><br></td>
<td>c:\program files\apache group\realdocs\files\antiquesbasic\images</td>
</tr>
<td colspan="2" align="CENTER">
<INPUT TYPE="submit" VALUE="upload">
</td>
</tr>
</FORM>
<?php
if (isset($submit)) {
$db = mysql_connect("localhost","root");
mysql_select_db("antiques",$db);
mysql_query($sql) or die(mysql_error());
$sql = "INSERT INTO general (name,description,price,image_name) VALUES ('$name','$description','$price','$image_name')";
}
?>
</body>

...Where up_go.php sends the image to image folder and renames it to whatever the user renamed it to.

van__

this...
if (isset($submit)) {

}

is wrong.
There is no $HTTP_POST_VAR returned for submit, it is only an interface control, but sends no data to the server per the w3c specification. So, your query was never sent becuase $submit was never set.

use is_array($HTTP_POST_VARS) instead.