Prevent opendir() from scanning subdirs?

[Anon]

<?
$dir = \'/path/goes/here/\';
$htmldir = \'http://www.dtfusion.com/randomsplash/splashes/\';
$opendir = opendir($dir);
while ($file = readdir($opendir))
$array[] = $file;
closedir($opendir);
shuffle($array);
for ($x = 0; $x < 1; $x++ )
{
include($htmldir.$array[$x]);
}
?>

As you can probably tell, I am attempting to make a random splash script that searches the specified directory for html files and randomly displays one of them. This script is fully functional, although occasionally it will bring up the apache directory listing for subfolders of the $dir directory. I was wondering if anybody knew of any ways to prevent it from doing so. Thanks!

Chuck

[Anon]

Just get whatever is not a dir:

while ($file = readdir($opendir)) {
if (!is_dir($file)) $array[] = $file;
}

Diego

[Anon]

Hey Diego, thanks for the idea but that's not helping the problem out at all. It is still occasionally calling up the images directory. Right now my code looks like
<?
$dir = '/path/goes/here/';
$htmldir = 'http://www.dtfusion.com/randomsplash/splashes/';
$opendir = opendir($dir);
while ($file = readdir($opendir))
{
if (!is_dir($file))
if($file_type = "text/html")
{
$array[] = $file;
}
}
closedir($opendir);
shuffle($array);
for ($x = 0; $x < 1; $x++ )
{
include($htmldir.$array[$x]);
}
?>

Yet, it is still not working. Perhaps the url might help so you can see the problem in action? It is at http://www.dtfusion.com/randomsplash. You may need to hit refresh quite a few times to see the error though. Thanks!!

chuck

[neo644]

add this:
if (!is_dir($file) && $file != "." && $file != ".." )

[Anon]

if($file_type = "text/html")

That's not right...The variable $file_type you only get it when it is an upload. In this case, $file_type is nothing. Also, you're using '=' when you should be using '=='

Diego

[Anon]

But '.' and '..' are also directories, so is_dir() takes care of them, and so he doesn't need to specifically weed them out.

Diego