Argh

Anon

Can anyone tell me why this is not recieving the "id" and $php_self variables into <a href.. tag, when the page is displyed these values are not in the code.
Thanks..

<body>

<?php

$db = mysql_connect("localhost", "root");

mysql_select_db("antiques",$db);

$result = mysql_query("SELECT * FROM general",$db);

if ($myrow = mysql_fetch_array($result)) {

echo "<table>\n";

echo "<tr><td>Name</td><td>Description</td><td>Price</td><td>Image Name</td></tr>\n";

do {

printf("<tr><td>%s </td><td>%s </td><td>%s </td><td>%s \n", $myrow["name"], $myrow["description"], $myrow["price"],"<img src=\"images/".$myrow["image_name"]."\">");

 printf("<td>%s </tr>\n","<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]);

} while ($myrow = mysql_fetch_array($result));

echo "</table>\n";

} else {

echo "Sorry, no records were found!";

}
if ($delete) {

$sql = "DELETE FROM general WHERE id=$id";	

$result = mysql_query($sql);

echo "$sql Record deleted!<p>";}

</body>

Anon

printf("<td>%s </tr>\n","<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]);

This is your first argument:
"<td>%s </tr>\n"
and this is your second argument:
"<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>"

Both of them contain the format string %s, but only the first argument should have that.
You'll have to put both those strings into one.

Diego

Anon

sorry, i am really new to this stuff, do you mean like this?

printf("<tr><td>%s </td><td>%s </td><td>%s </td><td>%s </td><td><a href=\"%s?id=%s&delete=yes\">(DELETE)</a></tr>\n", $myrow["name"], $myrow["description"], $myrow["price"],"<img src=\"images/".$myrow["image_name"]."\">, $PHP_SELF, $myrow["id"]);

frigidman

Uhm, why don't you just simplify it by doing:

while ($myrow = mysql_fetch_array($result)) {

echo "<tr>
<td>$myrow[name]</td>
<td>$myrow[description]</td>
<td>$myrow[price]</td>
<td><img src=\"images/".$myrow[image_name]."\"></td>
<td><a href=\"$PHP_SELF?id=$myrow[id]&delete=yes\">(DELETE)</a></td>
</tr>\n";

}

Not only is it easier to read yourself, it also helps prevent some nasty errors like the ones you were having.

Anon

cheers that makes a lot more sense...and works better as well...cheers