forced downloads - getting corrupted..

[amos_]

Okies,

Im current working on a section that previously has worked ok, (file.php)It involves forcing downloads using headers etc..

The only differences injected today is to store files in

./files/"md5hash of (Casename + Casenumber)"/
as opposed to..
./files/

The code ive been using for the forced downloads is as follows..

	$filename = dl_file($f,$casenum);

	$filepath = $working_dir."/".md5("case".$casenum)."/".$filename;
	echo $filepath;

	if (strlen($filepath)!=0) {

		$filename = basename($filepath);

		if (is_file($filepath)) {
			$size = filesize($filename);				

			header("Content-Type: application/x-ms-download");
      			header("Content-Type: application/force-download");
       			header("Content-Length: $size");

			if (preg_match("/MSIE 5.5/", $HTTP_USER_AGENT) || stristr($HTTP_USER_AGENT, "MSIE")) {
				header("Content-Disposition: filename=$filename");
       			} else {
			header("Content-Disposition: attachment;filename=$filename");
       			}

       			header("Content-Transfer-Encoding: binary");

       			$fh = fopen($filepath, "r");
       			fpassthru($fh);

			$op == '';
		}

	}

As i said this code was working before hand.. so what now happens is that

txt (and other) files come down with the content of txt file in the middle of a copy of my file.php..

by this i mean..

somefile.txt comes down as ...

---

header info from file.php

contents of somefile.txt

and then end bits of file.php

---

pdf,jpg,xls,doc files come down corrupted (i am presuming some of file.php is getting into the copy

Could it be something ive done in php.ini? or am i just over-worked enough to not notice something f***ing stupid

Thanks in advance..
Amos

[Anon]

Hi,

Try removing the echo $filepath; If you send any output, the header() doesn't work.

Josemi

[amos_]

hahaha,

The echo is only there for debugging, its normally commented out

Env is: Win2k, IIS5, Oracle8i..

The wierd thing is zip files download fine.
Which confuses me further.. as in.. why would extra crap be inserted into files such as txt, jpgs.. etc..

Does anyone have a working example of forced downloads..

Ive tried this on both Apache and IIS, so i think i can throw that idea out...

thanks

amos

[amos_]

Damn it.

The force download is working now..
But im getting about 10-12k extra content in all my files.. this being either html/php from the php file where the download was initiated from..

heres the code...

	$filename = basename($filepath);
	$size = filesize($filepath);


	header("Content-Type: application/octet-stream");
      	header("Content-Type: application/force-download");
       	header("Content-Length: $size");

	if (preg_match("/MSIE 5.5/", $HTTP_USER_AGENT)) {
		header("Content-Disposition: filename=$filename");
       	} else {
		header("Content-Disposition: attachment;filename=$filename");
       	}

       	header("Content-Transfer-Encoding: binary");

	log_file_action($userid, 'File downloaded ('.$f.') - '.$filename, $host, $f, $casenum, '32');
       	//@readfile($filepath);
	flush();
	$fh = fopen($filepath, "rb");
       	fpassthru($fh);

Anyone have an ideas where the crap in my files is coming from..

Thanks in Advance

Amos