arrays and mail()

[dskweb]

I'm working on a user authorization script and have everything working except for the admin function "Email Users".

The script works fine as long as no users have been deleted from the system. Once a user has been deleted, it leaves a "hole" in the user ID, making it harder to loop through them to pull out email addresses.

To work around it, I used arrays and simply looped through them instead, but I'm still getting the same problem.

I'm certain it is an array looping error because the function gets all of the email addresses and adds them to the array without a problem (the instruction $number_of_users = count($user_list); returns an accurate number).

I've spent several hours trying to figure it out, but I'm still a bit new to PHP. Any suggestions?

Here is the function:

function email_users($from, $subj, $message, $contact) {

mysql_connect($this->server, $this->db_user, $this->db_pass);
mysql_select_db($this->database);

$query1 = mysql_query("select * from data");
$num_users = mysql_num_rows($query1);

$count = 0;
$id_count = 0;
$user_list = array();

while ($count <= $num_users) {

	$query2 = mysql_query("select id, email from data where id = '$id_count'");
	$result = mysql_num_rows($query2);

	if ($result > 1) {
		$id_count++; }

	else {

		list($data_id, $email) = mysql_fetch_row($query2);

		if ($contact == 1) {	
			$query3 = mysql_query("select contact, admin from login where id = '$data_id'");
			list($cont, $admin) = mysql_fetch_row($query3);
			if ($cont == 1) {
				array_push( $user_list, $email ); } }

		if ($contact == 2) {	
			$query3 = mysql_query("select contact, admin from login where id = '$data_id'");
			list($cont, $admin) = mysql_fetch_row($query3);
			if ($admin == 2) {
				array_push( $user_list, $email ); } }

		if ($contact == 3) {	
			array_push( $user_list, $email ); }

		$id_count++;
		$count++; }

	}

$number_of_users = count($user_list);

if ($number_of_users == 0) {
	return false; }

for ($i = 0; $i <= $number_of_users; $i++) {
	@mail($user_list[$i], $subj, "-----\nThis message has been sent by $from, an Administrator of the $this->co_name Membership System.\n-----\n\n$message", "From: $this->admin"); }

return $number_of_users;

}

[[deleted]]

not sure what you're trying to do, code is hard to read and you have 3 select statements, 1 to get a count of a database that you're going to read for the same amount of records anyway, then you use the variable contact in an if statement but you do exactely the same query, so it's very confusing!!!!!!!!!!!!!!!

If you could explain your database and tell us what you're trying to do it would be simpler than trying to understand the code 🙂

[[deleted]]

I'm sorry... first, the function is called via form where the admin enters the subject of the message ($subj), the message itself ($message), and who the message should go to ($contact).

It is setup in the database so that users can choose to receive announcements or not. The admin has the option of sending a normal message (meaning it would only go to users who have said it is OK to get messages... $contact == 1), send it to admins only ($contact == 2), or send to all users regardless of their choice ($contact == 3). That's what the second set of loops does.

There are two tables in the database, one that holds login information (the login table holds the login_id, username, password, contact setting, and their admin flag (1 for normal, 2 for admin). The other one holds all the user information (email, name, address, phone, etc.).

Does this help in explaining the script more in detail?

[[deleted]]

OK... nevermind! After sleeping and looking at the code again, I realized my mistake... I simply had a greater-than sign instead of a less-than sign in a key place.