var misteriously looses its value.

Anon

Hi People,

Iam myself if anybody of you have been in this problem before.. because during the past week Ive had it twice.

For example.. look at this code here:
http://www.net.co.cr/code.txt

Watch line 14 and 29 (ignore the //), if I upload the script with the first exit executable as I said itll have the value, Now if I take away that exit and put it on line 29 the value of the var is gone.

I tried naming the vars diffrently just in case they get redefined somewhere else, but no luck.

I know I have some messy if statements, could that be the cause?

Anon

Okey.. I cleaned up the code.. but the the var still looses the value.

The new code is here:
www.net.co.cr/code2.txt

Anon

That's because you are declaring $db_id in the first if-statement, and try to use it in the elseif statement. If the elseif statement executes, it means that the if statement didn't execute, right? If the if-statement didn't execute, then $db_id is never declared!

Diego

Anon

Diego..

Ok.. according to you this should be the solution:

www.net.co.cr/code3.txt

However that doesnt work either.. the var doesnt get to the elseif in line 28

Any ideas?

van__

Simple problem, you placed your var in an if statement that was only for a particular instance.

Here's how it shold be...

 1	<?

 4	$dir = @opendir("database") or die("Error opening directory");
 5	$found = false;
 6	while ( $dir_name = readdir($dir) ) {
 7	list($db_id, $db_email) = explode("]", $dir_name);
 8	$db_id = substr($db_id, 1);
 9	if ( $db_email == "$email" ) {
10	$found = true;
11	break; }}

 2	if ("$action" == "do_profile_login" )
 3	{

12	
13	if ($found) {
14	//exit("$db_id"); <- if this is executed the var DOES have a value
15	$fd = fopen("database/$dir_name", "r");
16	$contents = fread ($fd, filesize("database/$dir_name"));
17	$delimeter = chr(135);
18	$pieces = explode("$delimeter", $contents);
19	if ($pieces[3] == $password) { require("html/profile_update.html"); } else { echo "Wrong Pass"; }
20	fclose ($fd);
21	} else {
22	print "Your profile was not found!";
23	}
24	}

majik-sheff

I feel as if my brain has been put through a blender reading that code. Your problem is right at the beginning.

if($action == "Update my Profile!" or $action == "do_profile_login") {

should read:

if($action == "Update my Profile!" || $action == "do_profile_login") {

you used the "or" operator instead of "||" check out the PHP manual on operator precedence to understand why your version is broken. Oh, and I e-mailed you a reformatted version of your code. 🙂

majik-sheff

<?PHP

if($action == "Update my Profile!" || $action == "do_profile_login") {
$dir = @opendir("database") or die("Error opening directory");
$found = false;
while ( $dir_name = readdir($dir) ) {
list($db_id, $db_email) = explode("]", $dir_name);
$db_id = substr($db_id, 1);
if ( $db_email == "$email" ) {
$found = true;
break;
}
}
}

if ("$action" == "do_profile_login" ) {
if ($found) {
$fd = fopen("database/$dir_name", "r");
$contents = fread ($fd, filesize("database/$dir_name"));
$delimeter = chr(135);
$pieces = explode("$delimeter", $contents);
if ($pieces[3] == $password) {
require("html/profile_update.html");
} else {
echo "Wrong Pass";
}
fclose ($fd);
} else {
print "Your profile was not found!";
}
} elseif ($action == "Update my Profile!") {
//We will now check if the user is attempting to upload something. If he is we will validate the upload ,if anything is wrong return to the registration form with an error msg.
if (!empty($img_name)) {
$img_info = GetImageSize($img);
if ($img_info[0] >= 318 or $img_info[1] >= 280) {
$error = 'Error: Pic exceeds the maximum pixel dimension of 318X280!';
include("html/register_form.html");
exit();
} elseif ($img_info[2] != "1" && $img_info[2] != "2") {
$error = 'Error: The pic is not in jpg or gif format!';
include("html/register_form.html");
exit();
}
} elseif (empty($Name)) {
//End upload validation
//Now we will validate all other data, if anything is wrong return to the registration form with an error msg.
$error = 'Error: You did not give us your name!';
require("html/profile_update.html");
exit();
} elseif (empty($E_Mail)) {
$error = 'Error: You did not give us your e-mail address!';
require("html/profile_update.html"); exit();
} elseif (strpos($E_Mail, chr(64)) === false) {
$error = 'Error: The e-mail address you supplied is invalid!';
require("html/profile_update.html");
exit();
} elseif (!empty($img_name)) {
//End data validation
//If the user wants to upload something we will now copy it from his HD to the server. We will also delete the previous image if any.
if(!empty($pieces[14])) {
unlink("mem_pics/[$db_id]$pieces[14]") or die("Unable to delete your previous pic");
}
copy("$img", "mem_pics/[$db_id]$img_name") or die("An error ocurred why attempting to upload your pic.");
}
//End file upload/deletion
//At this point the user has past all validation verification, we will now delete their past profile, and create a new one.
unlink("database/[$db_id]$db_email") or die("Unable to update your profile.");
$new_db = fopen("database/[$db_id]$E_Mail", "w");
fputs($new_db, "$Name$delimeter$E_Mail$delimeter$Date_Of_Birth$delimeter$password$delimeter$country$delimeter$city$delimeter$Sex$delimeter$Status$delimeter$mobno$delimeter$SeeMobMo$delimeter$website$delimeter$chatnick$delimeter$favchan$delimeter$comments$delimeter$img_name$delimeter$img_info[3]$delimeter");
//End of profile update
echo "Success $Name!!!, your profile was updated";
} else {
require("html/profile_login.html");
}
?>